Issue 335343006: Pepper: Small cleanup in PNaClCoordinator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 335343006: Pepper: Small cleanup in PNaClCoordinator. (Closed)

Created:
6 years, 6 months ago by teravest

Modified:
6 years, 6 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Pepper: Small cleanup in PNaClCoordinator. This simplifies the case where we fail to open all the necessary temporary files as part of PNaCl translation. RunTranslate() isn't called if num_object_files_opened_ != split_module_count_ anyway, so this should be equivalent to the existing behavior. BUG=239656

Patch Set 1 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -15 lines)			Patch
	M	ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc	View		5 chunks	+9 lines, -14 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/335343006/20001

6 years, 6 months ago (2014-06-18 18:24:37 UTC) #4

teravest

This is submitted, but "git cl dcommit" has been having problems with closing issues for ...

6 years, 6 months ago (2014-06-18 20:33:15 UTC) #5

commit-bot: I haz the power

6 years, 6 months ago (2014-06-18 20:34:45 UTC) #6

Message was sent while issue was closed.

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

Expand Messages | Collapse Messages