Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 335343005: Fix subzero build for mac (Closed)

Created:
6 years, 6 months ago by Derek Schuff
Modified:
6 years, 6 months ago
Reviewers:
Jim Stichnoth, JF
CC:
native-client-reviews_googlegroups.com
Base URL:
/Users/dschuff/code/nacl/native_client/toolchain_build/git_cache/chromium.googlesource.com-native_client-pnacl--subzero@master
Visibility:
Public.

Description

Fix subzero build for mac The subzero mac build fails with errors like the following: /Users/dschuff/code/nacl/native_client/toolchain_build/src/subzero/src/IceGlobalContext.cpp:116: error: ISO C++ forbids variable-size array 'NameBase' Replace the variable-length array with llvm::SmallVector which will still allow stack allocation most of the time. R=stichnot@chromium.org BUG=build subzero on the bots Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=44712d1

Patch Set 1 #

Patch Set 2 : fix format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M src/IceGlobalContext.cpp View 1 4 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Derek Schuff
A little ugly with all the .data() everywhere but this might be preferable to bringing ...
6 years, 6 months ago (2014-06-17 18:42:42 UTC) #1
Jim Stichnoth
LGTM, unless JF has any better ideas (e.g., OwningPtr).
6 years, 6 months ago (2014-06-17 21:07:11 UTC) #2
Derek Schuff
6 years, 6 months ago (2014-06-17 21:34:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r44712d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698