Add a DummySearchBoxView to the experimental app list start page.

ui/app_list/views/app_list_view_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/app_list_view.h"
 
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/strings/string_util.h"
+#include "base/strings/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/app_list/app_list_switches.h"
 #include "ui/app_list/pagination_model.h"
 #include "ui/app_list/test/app_list_test_model.h"
 #include "ui/app_list/test/app_list_test_view_delegate.h"
 #include "ui/app_list/views/app_list_folder_view.h"
 #include "ui/app_list/views/app_list_main_view.h"
 #include "ui/app_list/views/apps_container_view.h"
 #include "ui/app_list/views/apps_grid_view.h"
 #include "ui/app_list/views/contents_switcher_view.h"
 #include "ui/app_list/views/contents_view.h"
 #include "ui/app_list/views/search_box_view.h"
 #include "ui/app_list/views/search_result_list_view.h"
 #include "ui/app_list/views/start_page_view.h"
 #include "ui/app_list/views/test/apps_grid_view_test_api.h"
 #include "ui/app_list/views/tile_item_view.h"
 #include "ui/aura/test/aura_test_base.h"
 #include "ui/aura/window.h"
+#include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/test/views_test_base.h"
 #include "ui/views/views_delegate.h"
 #include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
 
 namespace app_list {
 namespace test {
 
 namespace {
 
 enum TestType {
@@ skipping 59 matching lines @@
     view_ = NULL;
     run_loop_->Quit();
   }
 
   // Whether the experimental "landscape" app launcher UI is being tested.
   bool is_landscape() const {
     return test_type_ == LANDSCAPE || test_type_ == EXPERIMENTAL;
   }
 
  private:
+  // Switches the active launcher page in the contents view and lays out to
+  // ensure all launcher pages are in the correct position.
+  void ShowContentsViewPage(int index);
+
   // Shows the app list and waits until a paint occurs.
   void Show();
 
   // Closes the app list. This sets |view_| to NULL.
   void Close();
 
   // Gets the PaginationModel owned by |view_|.
   PaginationModel* GetPaginationModel();
 
   const TestType test_type_;
@@ skipping 63 matching lines @@
 }
 
 // static
 void AppListViewTestContext::CheckView(views::View* subview) {
   ASSERT_TRUE(subview);
   EXPECT_TRUE(subview->parent());
   EXPECT_TRUE(subview->visible());
   EXPECT_TRUE(subview->IsDrawn());
 }
 
+void AppListViewTestContext::ShowContentsViewPage(int index) {
+  ContentsView* contents_view = view_->app_list_main_view()->contents_view();
+  contents_view->SetActivePage(index);
+  contents_view->Layout();
+  for (int i = 0; i < contents_view->NumLauncherPages(); ++i) {
+    EXPECT_EQ(i == index, IsViewAtOrigin(contents_view->GetPageView(i)));
+  }
+}
+
 void AppListViewTestContext::Show() {
   view_->GetWidget()->Show();
   run_loop_.reset(new base::RunLoop);
   view_->SetNextPaintCallback(run_loop_->QuitClosure());
   run_loop_->Run();
 
   EXPECT_TRUE(view_->GetWidget()->IsVisible());
 }
 
 void AppListViewTestContext::Close() {
@@ skipping 85 matching lines @@
   AppListMainView* main_view = view_->app_list_main_view();
   StartPageView* start_page_view =
       main_view->contents_view()->start_page_view();
   // Checks on the main view.
   EXPECT_NO_FATAL_FAILURE(CheckView(main_view));
   EXPECT_NO_FATAL_FAILURE(CheckView(main_view->contents_view()));
   if (test_type_ == EXPERIMENTAL) {
     EXPECT_NO_FATAL_FAILURE(CheckView(start_page_view));
 
     ContentsView* contents_view = main_view->contents_view();
-    contents_view->SetActivePage(contents_view->GetPageIndexForNamedPage(
+    ShowContentsViewPage(contents_view->GetPageIndexForNamedPage(
         ContentsView::NAMED_PAGE_START));
-    contents_view->Layout();
     EXPECT_FALSE(main_view->search_box_view()->visible());
-    EXPECT_TRUE(IsViewAtOrigin(start_page_view));
-    EXPECT_FALSE(IsViewAtOrigin(contents_view->apps_container_view()));
     EXPECT_EQ(3u, GetVisibleTileItemViews(start_page_view->tile_views()));
 
-    contents_view->SetActivePage(
+    ShowContentsViewPage(
         contents_view->GetPageIndexForNamedPage(ContentsView::NAMED_PAGE_APPS));
-    contents_view->Layout();
     EXPECT_TRUE(main_view->search_box_view()->visible());
-    EXPECT_FALSE(IsViewAtOrigin(start_page_view));
-    EXPECT_TRUE(IsViewAtOrigin(contents_view->apps_container_view()));
 
     // Check tiles hide and show on deletion and addition.
     model->CreateAndAddItem("Test app");
     EXPECT_EQ(4u, GetVisibleTileItemViews(start_page_view->tile_views()));
     model->DeleteItem(model->GetItemName(0));
     EXPECT_EQ(3u, GetVisibleTileItemViews(start_page_view->tile_views()));
   } else {
     EXPECT_EQ(NULL, start_page_view);
   }
 
@@ skipping 96 matching lines @@
 void AppListViewTestContext::RunSearchResultsTest() {
   EXPECT_FALSE(view_->GetWidget()->IsVisible());
   EXPECT_EQ(-1, GetPaginationModel()->total_pages());
   AppListTestModel* model = delegate_->GetTestModel();
   model->PopulateApps(3);
 
   Show();
 
   AppListMainView* main_view = view_->app_list_main_view();
   ContentsView* contents_view = main_view->contents_view();
-  contents_view->SetActivePage(
+  ShowContentsViewPage(
       contents_view->GetPageIndexForNamedPage(ContentsView::NAMED_PAGE_APPS));
   EXPECT_TRUE(IsViewAtOrigin(contents_view->apps_container_view()));
   EXPECT_TRUE(main_view->search_box_view()->visible());
 
   // Show the search results.
   contents_view->ShowSearchResults(true);
   contents_view->Layout();
   EXPECT_TRUE(contents_view->IsShowingSearchResults());
   EXPECT_TRUE(main_view->search_box_view()->visible());
 
@@ skipping 16 matching lines @@
         contents_view->IsNamedPageActive(ContentsView::NAMED_PAGE_START));
     EXPECT_TRUE(IsViewAtOrigin(contents_view->start_page_view()));
     EXPECT_FALSE(main_view->search_box_view()->visible());
   } else {
     EXPECT_TRUE(
         contents_view->IsNamedPageActive(ContentsView::NAMED_PAGE_APPS));
     EXPECT_TRUE(IsViewAtOrigin(contents_view->apps_container_view()));
     EXPECT_TRUE(main_view->search_box_view()->visible());
   }
 
+  if (test_type_ == EXPERIMENTAL) {
+    // Check that typing into the dummy search box triggers the search page.
+    base::string16 search_text = base::UTF8ToUTF16("test");
+    SearchBoxView* dummy_search_box =
+        contents_view->start_page_view()->dummy_search_box_view();
+    EXPECT_TRUE(dummy_search_box->IsDrawn());
+    dummy_search_box->search_box()->InsertText(search_text);
+    contents_view->Layout();
+    EXPECT_TRUE(contents_view->IsShowingSearchResults());
+    EXPECT_FALSE(dummy_search_box->IsDrawn());
+    EXPECT_TRUE(main_view->search_box_view()->visible());
+    EXPECT_EQ(search_text, main_view->search_box_view()->search_box()->text());
+    EXPECT_TRUE(
+        contents_view->IsNamedPageActive(ContentsView::NAMED_PAGE_START));
+    EXPECT_TRUE(IsViewAtOrigin(contents_view->start_page_view()));
+

[tapted, 2014/06/19 07:29:25]

// Check that the current search is using |search_text|.
EXPECT_EQ(search_text, delegate_->GetTestModel()->search_box()->text());

[calamity, 2014/06/19 08:21:47]

Done.

+    // Check that typing into the real search box triggers the search page.
+    ShowContentsViewPage(
+        contents_view->GetPageIndexForNamedPage(ContentsView::NAMED_PAGE_APPS));
+    EXPECT_TRUE(IsViewAtOrigin(contents_view->apps_container_view()));
+    main_view->search_box_view()->search_box()->InsertText(search_text);

[tapted, 2014/06/19 07:29:25]

perhaps a different search text? Then you can verify that the search in the
model changed.

[calamity, 2014/06/19 08:21:47]

Done.

+    EXPECT_TRUE(contents_view->IsShowingSearchResults());
+    EXPECT_FALSE(dummy_search_box->IsDrawn());
+    EXPECT_TRUE(main_view->search_box_view()->visible());
+
+    // Check that the dummy search box is cleared when reshowing the start page.

[tapted, 2014/06/19 07:29:25]

Should the dummy search box be already cleared here too? Since, focus has
changed to the real one already.

[calamity, 2014/06/19 08:21:47]

Done.

+    ShowContentsViewPage(
+        contents_view->GetPageIndexForNamedPage(ContentsView::NAMED_PAGE_APPS));

[tapted, 2014/06/19 07:29:24]

did you mean to do this as well as the next line? Or, maybe rename
ShowContentsViewPage -> ShowContentsViewPageAndVerify if that's the intention.

[calamity, 2014/06/19 08:21:47]

In this case I wanted to reset the start page by showing the apps page and then
the start page. In any case that's a better name.

+    ShowContentsViewPage(contents_view->GetPageIndexForNamedPage(
+        ContentsView::NAMED_PAGE_START));
+    EXPECT_TRUE(dummy_search_box->IsDrawn());
+    EXPECT_TRUE(dummy_search_box->search_box()->text().empty());
+  }
+
   Close();
 }
 
 class AppListViewTestAura : public views::ViewsTestBase,
                             public ::testing::WithParamInterface<int> {
  public:
   AppListViewTestAura() {}
   virtual ~AppListViewTestAura() {}
 
   // testing::Test overrides:
@@ skipping 133 matching lines @@
 INSTANTIATE_TEST_CASE_P(AppListViewTestAuraInstance,
                         AppListViewTestAura,
                         ::testing::Range<int>(TEST_TYPE_START, TEST_TYPE_END));
 
 INSTANTIATE_TEST_CASE_P(AppListViewTestDesktopInstance,
                         AppListViewTestDesktop,
                         ::testing::Range<int>(TEST_TYPE_START, TEST_TYPE_END));
 
 }  // namespace test
 }  // namespace app_list