Issue 335333002: Make "descriptors" argument of FontFace constructor optional

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 335333002: Make "descriptors" argument of FontFace constructor optional (Closed)

Created:
6 years, 6 months ago by Kunihiko Sakamoto

Modified:
6 years, 6 months ago

Reviewers:
dglazkov, bashi

CC:
darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-css, Inactive, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink, watchdog-blink-watchlist_google.com

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Make "descriptors" argument of FontFace constructor optional This reflects recent spec update. spec: http://dev.w3.org/csswg/css-font-loading/#fontface-interface BUG= TEST=fast/css/font* Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176329

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -11 lines)			Patch
M	LayoutTests/fast/css/fontface-arraybuffer.html	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/css/fontface-properties.html	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/css/fontface-properties-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/FontFace.idl	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bashi

On 2014/06/17 10:59:33, Kunihiko Sakamoto wrote: non-owner LGTM.

6 years, 6 months ago (2014-06-17 11:15:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/335333002/1

6 years, 6 months ago (2014-06-17 15:09:08 UTC) #4

Message was sent while issue was closed.

Change committed as 176329

Expand Messages | Collapse Messages