src/scanner.h - Issue 335293004: New try: Parser: Delay internalizing strings and values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/scanner.h

Issue 335293004: New try: Parser: Delay internalizing strings and values (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: variable renaming + passing const & Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/scanner.h

diff --git a/src/scanner.h b/src/scanner.h

index 2979082e3f152623527df8a69a4b2d177f592323..7d8b2ab4f222a428559b340f0cac1d16c872f714 100644

--- a/src/scanner.h

+++ b/src/scanner.h

@@ -21,6 +21,8 @@ namespace v8 {

namespace internal {

+class AstString;

+class AstValueFactory;

class ParserRecorder;

@@ -376,9 +378,8 @@ class Scanner {

return next_.literal_chars->is_contextual_keyword(keyword);

}

- Handle<String> AllocateNextLiteralString(Isolate* isolate,

- PretenureFlag tenured);

- Handle<String> AllocateInternalizedString(Isolate* isolate);

+ const AstString* CurrentSymbol(AstValueFactory* ast_value_factory);

+ const AstString* NextSymbol(AstValueFactory* ast_value_factory);

double DoubleValue();

bool UnescapedLiteralMatches(const char* data, int length) {