Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 335293003: Add slots for navigator.serviceWorker.installing and active. (Closed)

Created:
6 years, 6 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 6 months ago
Reviewers:
falken, tkent
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, jamesr, tzik, serviceworker-reviews, nhiroki, abarth-chromium, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Add slots for navigator.serviceWorker.installing and active. These are not set by the embedder yet, so the value is always null. BUG=379012 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -23 lines) Patch
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/serviceworker/serviceworkercontainer-interface.html View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 1 chunk +9 lines, -6 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 3 chunks +20 lines, -7 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M public/platform/WebServiceWorkerProviderClient.h View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dominicc (has gone to gerrit)
PTAL
6 years, 6 months ago (2014-06-17 04:22:44 UTC) #1
falken
lgtm, but the bug # in the CL description is off by one
6 years, 6 months ago (2014-06-17 04:38:47 UTC) #2
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-18 01:00:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/335293003/1
6 years, 6 months ago (2014-06-18 01:01:17 UTC) #4
dominicc (has gone to gerrit)
The CQ bit was unchecked by dominicc@chromium.org
6 years, 6 months ago (2014-06-18 01:36:54 UTC) #5
dominicc (has gone to gerrit)
tkent, can I get OWNERs approval for public/platform/WebServiceWorkerProviderClient.h ?
6 years, 6 months ago (2014-06-18 01:37:52 UTC) #6
tkent
lgtm
6 years, 6 months ago (2014-06-18 01:43:16 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 02:17:00 UTC) #8
Message was sent while issue was closed.
Change committed as 176377

Powered by Google App Engine
This is Rietveld 408576698