Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 335263002: Make JSON validity presubmit test less stringent. (Closed)

Created:
6 years, 6 months ago by Yoyo Zhou
Modified:
6 years, 6 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, lliabra
Project:
chromium
Visibility:
Public.

Description

Make JSON validity presubmit test less stringent. On Mac, Python 2.7 gives different results (line 1 column 3 char 2) than Python 2.6 (line 1 column 2 char 2). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277728

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M PRESUBMIT_test.py View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yoyo Zhou
6 years, 6 months ago (2014-06-17 00:38:56 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 6 months ago (2014-06-17 00:48:29 UTC) #2
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 6 months ago (2014-06-17 00:52:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/335263002/1
6 years, 6 months ago (2014-06-17 00:53:17 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 11:41:56 UTC) #5
Message was sent while issue was closed.
Change committed as 277728

Powered by Google App Engine
This is Rietveld 408576698