Clean up temp dirs when breaking locks.

git_cache.py

Index: git_cache.py
diff --git a/git_cache.py b/git_cache.py
index 92332808fe0758d46cd4a8170667280a16051926..913ef50a113e87142c9e8cebd5ca2bfb24ba0e63 100755
--- a/git_cache.py
+++ b/git_cache.py
@@ -278,7 +278,7 @@ class Mirror(object):
 
     # Download zip file to a temporary directory.
     try:
-      tempdir = tempfile.mkdtemp()
+      tempdir = tempfile.mkdtemp(prefix='_cache_tmp', dir=self.GetCachePath())
       self.print('Downloading %s' % latest_checkout)
       code = gsutil.call('cp', latest_checkout, tempdir)
       if code:
@@ -344,7 +344,7 @@ class Mirror(object):
                           len(pack_files) > GC_AUTOPACKLIMIT)
       if should_bootstrap:
         tempdir = tempfile.mkdtemp(
-            suffix=self.basedir, dir=self.GetCachePath())
+            prefix='_cache_tmp', suffix=self.basedir, dir=self.GetCachePath())
         bootstrapped = not depth and bootstrap and self.bootstrap_repo(tempdir)
         if bootstrapped:
           # Bootstrap succeeded; delete previous cache, if any.
@@ -408,8 +408,8 @@ class Mirror(object):
       except OSError:
         logging.warn('Unable to delete temporary pack file %s' % f)
 
-  @staticmethod
-  def BreakLocks(path):
+  @classmethod
+  def BreakLocks(cls, path):
     did_unlock = False
     lf = Lockfile(path)
     if lf.break_lock():
@@ -420,6 +420,7 @@ class Mirror(object):
     if os.path.exists(lf):
       os.remove(lf)
       did_unlock = True
+    cls.DeleteTmpPackFiles(path)

[Ryan Tseng, 2014/06/17 01:00:44]

Is this implemented somewhere....?

[szager1, 2014/06/17 15:04:12]

It's defined just before this method.

     return did_unlock
 
   def unlock(self):
@@ -432,12 +433,16 @@ class Mirror(object):
     repo_dirs = set([os.path.join(cachepath, path) for path in dirlist
                      if os.path.isdir(os.path.join(cachepath, path))])
     for dirent in dirlist:
+      if dirent.startswith('_cache_tmp'):
+        gclient_utils.rmtree(os.path.join(cachepath, dirent))
       if (dirent.endswith('.lock') and
           os.path.isfile(os.path.join(cachepath, dirent))):
         repo_dirs.add(os.path.join(cachepath, dirent[:-5]))
 
     unlocked_repos = []
     for repo_dir in repo_dirs:
+      if os.path.basename(repo_dir).startswith('tmp'):
+        gclient_utils.rmtree(repo_dir)
       if cls.BreakLocks(repo_dir):
         unlocked_repos.append(repo_dir)