Issue 335253002: Clean up temp dirs when breaking locks.

Issue 335253002: Clean up temp dirs when breaking locks. (Closed)

Created:
6 years, 6 months ago by szager1

Modified:
6 years, 6 months ago

Reviewers:
Ryan Tseng, agable, hinoka

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Clean up temp dirs when breaking locks. A number of bots have been running out of disk space because they are accumulating temp dirs and temp pack files. Be more careful to clean up temp dirs whenever UnlockAll() is called. R=hinoka@chromium.org,agable@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=277812

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	git_cache.py	View	1	5 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ryan Tseng

mostly lg, theres a function i can't seem to find... https://codereview.chromium.org/335253002/diff/1/git_cache.py File git_cache.py (right): https://codereview.chromium.org/335253002/diff/1/git_cache.py#newcode423 ...

6 years, 6 months ago (2014-06-17 01:00:44 UTC) #2

szager1

https://codereview.chromium.org/335253002/diff/1/git_cache.py File git_cache.py (right): https://codereview.chromium.org/335253002/diff/1/git_cache.py#newcode423 git_cache.py:423: cls.DeleteTmpPackFiles(path) On 2014/06/17 01:00:44, Ryan T. wrote: > Is ...

6 years, 6 months ago (2014-06-17 15:04:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/335253002/20001

6 years, 6 months ago (2014-06-17 18:24:38 UTC) #6

Message was sent while issue was closed.

Change committed as 277812

Expand Messages | Collapse Messages