Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: chrome/browser/favicon/favicon_handler.cc

Issue 335233003: Convert ui::ScaleFactor -> float in favicon/history code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_handler.cc
diff --git a/chrome/browser/favicon/favicon_handler.cc b/chrome/browser/favicon/favicon_handler.cc
index be6d9af9c5c4524b4f7ed59bb4e0cea678f608f1..c7ebe28369e33e1644c1fb29c29e074fccfd3ae2 100644
--- a/chrome/browser/favicon/favicon_handler.cc
+++ b/chrome/browser/favicon/favicon_handler.cc
@@ -7,6 +7,7 @@
#include "build/build_config.h"
#include <algorithm>
+#include <cmath>
#include <vector>
#include "base/bind.h"
@@ -123,11 +124,9 @@ bool HasExpiredOrIncompleteResult(
for (size_t i = 0; i < bitmap_results.size(); ++i)
favicon_sizes.push_back(bitmap_results[i].pixel_size);
- std::vector<ui::ScaleFactor> scale_factors =
- favicon_base::GetFaviconScaleFactors();
- for (size_t i = 0; i < scale_factors.size(); ++i) {
- int edge_size_in_pixel = floor(
- desired_size_in_dip * ui::GetScaleForScaleFactor(scale_factors[i]));
+ std::vector<float> favicon_scales = favicon_base::GetFaviconScales();
+ for (size_t i = 0; i < favicon_scales.size(); ++i) {
+ int edge_size_in_pixel = std::ceil(desired_size_in_dip * favicon_scales[i]);
std::vector<gfx::Size>::iterator it = std::find(favicon_sizes.begin(),
favicon_sizes.end(), gfx::Size(edge_size_in_pixel, edge_size_in_pixel));
if (it == favicon_sizes.end())
@@ -317,7 +316,7 @@ void FaviconHandler::SetFaviconOnActivePage(const std::vector<
favicon_base::FaviconRawBitmapResult>& favicon_bitmap_results) {
gfx::Image resized_image = favicon_base::SelectFaviconFramesFromPNGs(
favicon_bitmap_results,
- favicon_base::GetFaviconScaleFactors(),
+ favicon_base::GetFaviconScales(),
preferred_icon_size());
// The history service sends back results for a single icon URL, so it does
// not matter which result we get the |icon_url| from.
@@ -428,11 +427,9 @@ void FaviconHandler::OnDidDownloadFavicon(
if (index != -1)
image_skia = gfx::ImageSkia(gfx::ImageSkiaRep(bitmaps[index], 1));
} else {
- std::vector<ui::ScaleFactor> scale_factors =
- favicon_base::GetFaviconScaleFactors();
image_skia = SelectFaviconFrames(bitmaps,
original_bitmap_sizes,
- scale_factors,
+ favicon_base::GetFaviconScales(),
preferred_icon_size(),
&score);
}

Powered by Google App Engine
This is Rietveld 408576698