Add trial for DirectWrite, and reorder some initialization so it can take effect

content/renderer/renderer_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/debug/debugger.h"
 #include "base/debug/stack_trace.h"
 #include "base/debug/trace_event.h"
 #include "base/i18n/rtl.h"
@@ skipping 160 matching lines @@
   main_message_loop.AddTaskObserver(&task_observer);
 
   scoped_ptr<MemoryObserver> memory_observer;
   if (parsed_command_line.HasSwitch(switches::kMemoryMetrics)) {
     memory_observer.reset(new MemoryObserver());
     main_message_loop.AddTaskObserver(memory_observer.get());
   }
 
   base::PlatformThread::SetName("CrRendererMain");
 
-  platform.PlatformInitialize();
-
   bool no_sandbox = parsed_command_line.HasSwitch(switches::kNoSandbox);
 
   // Initialize histogram statistics gathering system.
   base::StatisticsRecorder::Initialize();
 
   // Initialize statistical testing infrastructure.  We set the entropy provider
   // to NULL to disallow the renderer process from creating its own one-time
   // randomized trials; they should be created in the browser process.
   base::FieldTrialList field_trial_list(NULL);
   // Ensure any field trials in browser are reflected into renderer.
   if (parsed_command_line.HasSwitch(switches::kForceFieldTrials)) {
     // Field trials are created in an "activated" state to ensure they get
     // reported in crash reports.
     bool result = base::FieldTrialList::CreateTrialsFromString(
         parsed_command_line.GetSwitchValueASCII(switches::kForceFieldTrials),
         base::FieldTrialList::ACTIVATE_TRIALS,
         std::set<std::string>());
     DCHECK(result);
   }
 
+  // PlatformInitialize uses FieldTrials, so this must happen later.

[jamesr, 2014/06/17 21:04:20]

how does PlatformInitialize depend on FieldTrials?  Does FieldTrials manipulate
the current command line or something ridiculous like that?  I don't see
anything in PlatformInitialize that asks the field trials system any questions

+  platform.PlatformInitialize();
+
 #if defined(ENABLE_PLUGINS)
   // Load pepper plugins before engaging the sandbox.
   PepperPluginRegistry::GetInstance();
 #endif
 #if defined(ENABLE_WEBRTC)
   // Initialize WebRTC before engaging the sandbox.
   // NOTE: On linux, this call could already have been made from
   // zygote_main_linux.cc.  However, calling multiple times from the same thread
   // is OK.
   InitializeWebRtcModule();
@@ skipping 36 matching lines @@
       base::MessageLoop::current()->Run();
       TRACE_EVENT_END_ETW("RendererMain.START_MSG_LOOP", 0, 0);
     }
   }
   platform.PlatformUninitialize();
   TRACE_EVENT_END_ETW("RendererMain", 0, "");
   return 0;
 }
 
 }  // namespace content