Show spinner for constrained signin flow

Show spinner for constrained signin flow

and change the spinner background color to the same as EmbeddedSignin, otherwise user may see flicker.

BUG=385876
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278283

[guohui, 2014-06-17 22:46:56]

Hey,

could you please review the CL?

Thanks,

Hui

[xiyuan, 2014-06-17 22:58:14]

https://codereview.chromium.org/335193002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/inline_login/inline_login.js (right):

https://codereview.chromium.org/335193002/diff/20001/chrome/browser/resources...
chrome/browser/resources/inline_login/inline_login.js:59: data.authMode !=
cr.login.GaiaAuthHost.AuthMode.DESKTOP ||
What does this do? Is it turning off the spinner when authMode ==
AuthMode.DESKTOP? Should we replace the test with "true" to show spinner in all
cases?

[guohui, 2014-06-18 18:44:04]

https://codereview.chromium.org/335193002/diff/20001/chrome/browser/resources...
File chrome/browser/resources/inline_login/inline_login.js (right):

https://codereview.chromium.org/335193002/diff/20001/chrome/browser/resources...
chrome/browser/resources/inline_login/inline_login.js:59: data.authMode !=
cr.login.GaiaAuthHost.AuthMode.DESKTOP ||
On 2014/06/17 22:58:14, xiyuan wrote:
> What does this do? Is it turning off the spinner when authMode ==
> AuthMode.DESKTOP? Should we replace the test with "true" to show spinner in
all
> cases?

this is to turn off spinner for full tab signin on desktop. With spinner, the
gaia iframe is initially invisible and thus has 0 height and and since gaia
tries to position the scroll bar based on the frame height thus the page would
scroll to the bottom unexpectedly.

[xiyuan, 2014-06-18 19:52:46]

Thanks for the explanation. LGTM.

[guohui, 2014-06-18 20:01:24]

The CQ bit was checked by guohui@chromium.org

[commit-bot: I haz the power, 2014-06-18 20:02:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/guohui@chromium.org/335193002/20001

[commit-bot: I haz the power, 2014-06-19 06:38:36]

Change committed as 278283