Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 335183002: Fixing install and OAuth (Closed)

Created:
6 years, 6 months ago by jcgregorio
Modified:
6 years, 6 months ago
Reviewers:
mtklein, benchen
CC:
reviews_skia.org, benchen, kelvinly
Base URL:
https://skia.googlesource.com/buildbot.git@master
Visibility:
Public.

Description

Some fixes for the setup script, and add the ability to use a service account when accessing the data from GCE. BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/8233bb584ddeef982aa2ffa132c5573d558ab1b6

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M perf/server/data.go View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M perf/server/perf.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M perf/server/setup/continue_install View 1 2 3 4 2 chunks +8 lines, -2 lines 0 comments Download
M perf/server/setup/perf_setup.sh View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M perf/server/setup/sys/perf_init View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
jcgregorio
6 years, 6 months ago (2014-06-16 19:50:44 UTC) #1
benchen
lgtm
6 years, 6 months ago (2014-06-16 20:07:36 UTC) #2
mtklein
https://codereview.chromium.org/335183002/diff/60001/perf/server/data.go File perf/server/data.go (right): https://codereview.chromium.org/335183002/diff/60001/perf/server/data.go#newcode20 perf/server/data.go:20: "code.google.com/p/goauth2/compute/serviceaccount" Am I thinking using a service account is ...
6 years, 6 months ago (2014-06-16 20:25:11 UTC) #3
jcgregorio
https://codereview.chromium.org/335183002/diff/60001/perf/server/data.go File perf/server/data.go (right): https://codereview.chromium.org/335183002/diff/60001/perf/server/data.go#newcode20 perf/server/data.go:20: "code.google.com/p/goauth2/compute/serviceaccount" There's a service account associated with the cloud ...
6 years, 6 months ago (2014-06-16 20:33:47 UTC) #4
mtklein
On 2014/06/16 20:33:47, jcgregorio wrote: > https://codereview.chromium.org/335183002/diff/60001/perf/server/data.go > File perf/server/data.go (right): > > https://codereview.chromium.org/335183002/diff/60001/perf/server/data.go#newcode20 > ...
6 years, 6 months ago (2014-06-16 20:39:29 UTC) #5
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 6 months ago (2014-06-16 20:41:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/335183002/60001
6 years, 6 months ago (2014-06-16 20:42:12 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 20:42:20 UTC) #8
commit-bot: I haz the power
Failed to apply patch for perf/server/setup/continue_install: While running git apply --index -p1; error: patch failed: ...
6 years, 6 months ago (2014-06-16 20:42:21 UTC) #9
jcgregorio
On 2014/06/16 20:42:21, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
6 years, 6 months ago (2014-06-16 20:46:22 UTC) #10
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 6 months ago (2014-06-16 20:46:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/335183002/80001
6 years, 6 months ago (2014-06-16 20:47:12 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 20:47:22 UTC) #13
Message was sent while issue was closed.
Change committed as 8233bb584ddeef982aa2ffa132c5573d558ab1b6

Powered by Google App Engine
This is Rietveld 408576698