runtime/vm/flow_graph_optimizer.cc - Issue 335173002: Save ICData of unoptimized code in the function, thus preserving it across repated unoptimized comp…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 335173002: Save ICData of unoptimized code in the function, thus preserving it across repated unoptimized comp… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

===================================================================

--- runtime/vm/flow_graph_optimizer.cc (revision 37375)

+++ runtime/vm/flow_graph_optimizer.cc (working copy)

@@ -1342,7 +1342,7 @@

const ICData& ic_data,

TargetEntryInstr** entry,

Definition** last) {

- ICData& value_check = ICData::ZoneHandle(isolate(), ICData::null());

+ ICData& value_check = ICData::ZoneHandle(isolate());

MethodRecognizer::Kind kind = MethodRecognizer::RecognizeKind(target);

switch (kind) {

// Recognized [] operators.

@@ -3664,7 +3664,7 @@

i_call = call->AsInstanceCall();

}

ASSERT(i_call != NULL);

- ICData& value_check = ICData::ZoneHandle(isolate(), ICData::null());

+ ICData& value_check = ICData::ZoneHandle(isolate());

switch (view_cid) {

case kTypedDataInt8ArrayCid:

case kTypedDataUint8ArrayCid:

« runtime/vm/flow_graph_compiler.cc ('K') | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | runtime/vm/object.cc » ('J')