Issue 335123010: Make LTCG optional on windows builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 335123010: Make LTCG optional on windows builds. (Closed)

Created:
6 years, 6 months ago by bsalomon

Modified:
6 years, 6 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Make LTCG optional on windows builds. Committed: https://skia.googlesource.com/skia/+/da07a083676f451499d9ea37881874f926e9d6be

Patch Set 1 #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -5 lines)			Patch
	M	gyp/common_conditions.gypi	View		3 chunks	+17 lines, -5 lines	1 comment	Download
	M	gyp/common_variables.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bsalomon

On my z620 With LTCG: Full build of SampleApp - 57s Incremental build of SampleApp ...

6 years, 6 months ago (2014-06-26 18:58:20 UTC) #1

mtklein

lgtm https://codereview.chromium.org/335123010/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/335123010/diff/1/gyp/common_conditions.gypi#newcode152 gyp/common_conditions.gypi:152: [ 'skia_win_ltcg', { Even skia_ltcg or just ltcg? ...

6 years, 6 months ago (2014-06-26 19:00:50 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/335123010/1

6 years, 6 months ago (2014-06-26 19:05:11 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-26 19:56:32 UTC) #5

Message was sent while issue was closed.

Change committed as da07a083676f451499d9ea37881874f926e9d6be

Expand Messages | Collapse Messages