Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: pkg/analysis_server/test/domain_analysis_test.dart

Issue 335123008: Implement analysis.updateOptions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/protocol.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/domain_analysis_test.dart
diff --git a/pkg/analysis_server/test/domain_analysis_test.dart b/pkg/analysis_server/test/domain_analysis_test.dart
index 87d0c31a75c39c6cb55ab2ae50dc920b6fb776ca..1667bdaf7db23a64faf3d4baf63e67825c767d02 100644
--- a/pkg/analysis_server/test/domain_analysis_test.dart
+++ b/pkg/analysis_server/test/domain_analysis_test.dart
@@ -12,6 +12,7 @@ import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/domain_analysis.dart';
import 'package:analysis_server/src/protocol.dart';
import 'package:analysis_server/src/resource.dart';
+import 'package:analyzer/src/generated/engine.dart';
import 'package:unittest/unittest.dart';
import 'mocks.dart';
@@ -113,18 +114,31 @@ main() {
});
});
- test('updateOptions', () {
- var request = new Request('0', ANALYSIS_UPDATE_OPTIONS);
- request.setParameter(
- OPTIONS,
- {
- 'analyzeAngular' : true,
- 'enableDeferredLoading': true,
- 'enableEnums': false
- });
- var response = handler.handleRequest(request);
- // TODO(scheglov) implement
- expect(response, isNull);
+ group('updateOptions', () {
+ test('invalid', () {
+ var request = new Request('0', ANALYSIS_UPDATE_OPTIONS);
+ request.setParameter(OPTIONS, {'not-an-option' : true});
+ var response = handler.handleRequest(request);
+ expect(response, isResponseFailure('0'));
+ });
+
+ test('valid', () {
+ AnalysisOptions options = server.contextDirectoryManager.defaultOptions;
+ bool analyzeAngular = !options.analyzeAngular;
+ bool enableDeferredLoading = options.enableDeferredLoading;
+ var request = new Request('0', ANALYSIS_UPDATE_OPTIONS);
+ request.setParameter(
+ OPTIONS,
+ {
+ 'analyzeAngular' : analyzeAngular,
+ 'enableDeferredLoading': enableDeferredLoading,
+ 'enableEnums': false
+ });
+ var response = handler.handleRequest(request);
+ expect(response, isResponseSuccess('0'));
+ expect(options.analyzeAngular, equals(analyzeAngular));
+ expect(options.enableDeferredLoading, equals(enableDeferredLoading));
+ });
});
test('updateSdks', () {
« no previous file with comments | « pkg/analysis_server/lib/src/protocol.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698