Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: pkg/analysis_server/lib/src/domain_analysis.dart

Issue 335123008: Implement analysis.updateOptions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/domain_analysis.dart
diff --git a/pkg/analysis_server/lib/src/domain_analysis.dart b/pkg/analysis_server/lib/src/domain_analysis.dart
index 5025d8cc7037647b1233f41886f93b052cde3e3a..c153735c579dfea141964c7e6e8bb2010cc087e9 100644
--- a/pkg/analysis_server/lib/src/domain_analysis.dart
+++ b/pkg/analysis_server/lib/src/domain_analysis.dart
@@ -6,6 +6,7 @@ library domain.analysis;
import 'dart:collection';
+import 'package:analyzer/src/generated/engine.dart';
import 'package:analysis_server/src/analysis_server.dart';
import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/protocol.dart';
@@ -125,8 +126,52 @@ class AnalysisDomainHandler implements RequestHandler {
Response updateOptions(Request request) {
// options
RequestDatum optionsDatum = request.getRequiredParameter(OPTIONS);
- // TODO(scheglov) implement
- return null;
+ List<OptionUpdater> updaters = new List<OptionUpdater>();
+ optionsDatum.forEachMap((String optionName, RequestDatum optionDatum) {
+ if (optionName == ANALYZE_ANGULAR) {
+ bool optionValue = optionDatum.asBool();
+ updaters.add((AnalysisOptionsImpl options) {
+ options.analyzeAngular = optionValue;
+ });
+ } else if (optionName == ANALYZE_POLYMER) {
+ bool optionValue = optionDatum.asBool();
+ updaters.add((AnalysisOptionsImpl options) {
+ options.analyzePolymer = optionValue;
+ });
+ } else if (optionName == ENABLE_ASYNC) {
+ // TODO(brianwilkerson) Uncomment this when the option is supported.
+// bool optionValue = optionDatum.asBool();
+// updaters.add((AnalysisOptionsImpl options) {
+// options.enableAsync = optionValue;
+// });
+ } else if (optionName == ENABLE_DEFERRED_LOADING) {
+ bool optionValue = optionDatum.asBool();
+ updaters.add((AnalysisOptionsImpl options) {
+ options.enableDeferredLoading = optionValue;
+ });
+ } else if (optionName == ENABLE_ENUMS) {
+ // TODO(brianwilkerson) Uncomment this when the option is supported.
+// bool optionValue = optionDatum.asBool();
+// updaters.add((AnalysisOptionsImpl options) {
+// options.enableEnums = optionValue;
+// });
+ } else if (optionName == GENERATE_DART2JS_HINTS) {
+ bool optionValue = optionDatum.asBool();
+ updaters.add((AnalysisOptionsImpl options) {
+ options.dart2jsHint = optionValue;
+ });
+ } else if (optionName == GENERATE_HINTS) {
+ bool optionValue = optionDatum.asBool();
+ updaters.add((AnalysisOptionsImpl options) {
+ options.hint = optionValue;
+ });
+ } else {
+ throw new RequestFailure(new Response.unknownOptionName(request,
+ optionName));
+ }
+ });
+ server.updateOptions(updaters);
+ return new Response(request.id);
}
/**

Powered by Google App Engine
This is Rietveld 408576698