Source/bindings/v8/V8StringResource.h - Issue 335113002: IDL: Support argument default values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8StringResource.h

Issue 335113002: IDL: Support argument default values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8StringResource.h

diff --git a/Source/bindings/v8/V8StringResource.h b/Source/bindings/v8/V8StringResource.h

index 69f849b31e96ede89691336cd3e205777abe3d23..968cac6d36d007599cc111206b5dca16724d0ed1 100644

--- a/Source/bindings/v8/V8StringResource.h

+++ b/Source/bindings/v8/V8StringResource.h

@@ -190,6 +190,11 @@ public:

setString(string);

}

+ void operator=(std::nullptr_t)

Nils Barth (inactive) 2014/06/17 03:40:32 BTW, is this going away, as |null| is invalid for

+ {

+ setString(String());

+ }

bool prepare()

{

if (m_v8Object.IsEmpty())