Source/bindings/scripts/v8_methods.py - Issue 335113002: IDL: Support argument default values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 335113002: IDL: Support argument default values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index dfb8460f0c3f6d8bc594efa8f0b424607978d6d5..6f8378d24fd8ec381513a5af52b3d70b4707b6e9 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -301,14 +301,7 @@ def v8_value_to_local_cpp_value(argument, index):

name = argument.name

if argument.is_variadic:

return v8_value_to_local_cpp_variadic_value(argument, index)

- # FIXME: This special way of handling string arguments with null defaults

- # can go away once we fully support default values.

- if (argument.is_optional and idl_type.name in ('String', 'ByteString') and

- argument.default_value and argument.default_value.is_null):

- v8_value = 'argumentOrNull(info, %s)' % index

- else:

- v8_value = 'info[%s]' % index

- return idl_type.v8_value_to_local_cpp_value(extended_attributes, v8_value,

+ return idl_type.v8_value_to_local_cpp_value(extended_attributes, 'info[%s]' % index,

name, index=index, declare_variable=False)