Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineView.js

Issue 335103003: Use TimelineUIUtils to create BeginFrame divider (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 frameStrip._frame = frame; 175 frameStrip._frame = frame;
176 this._frameStripByFrame.put(frame, frameStrip); 176 this._frameStripByFrame.put(frame, frameStrip);
177 177
178 const minWidthForFrameInfo = 60; 178 const minWidthForFrameInfo = 60;
179 if (width > minWidthForFrameInfo) 179 if (width > minWidthForFrameInfo)
180 frameStrip.textContent = Number.millisToString(frame.endTime - f rame.startTime, true); 180 frameStrip.textContent = Number.millisToString(frame.endTime - f rame.startTime, true);
181 181
182 this._frameContainer.appendChild(frameStrip); 182 this._frameContainer.appendChild(frameStrip);
183 183
184 if (actualStart > 0) { 184 if (actualStart > 0) {
185 var frameMarker = this._uiUtils.createEventDivider(WebInspector. TimelineModel.RecordType.BeginFrame); 185 var frameMarker = this._uiUtils.createBeginFrameDivider();
186 frameMarker.style.left = frameStart + "px"; 186 frameMarker.style.left = frameStart + "px";
187 dividers.push(frameMarker); 187 dividers.push(frameMarker);
188 } 188 }
189 } 189 }
190 this._timelineGrid.addEventDividers(dividers); 190 this._timelineGrid.addEventDividers(dividers);
191 this._headerElement.appendChild(this._frameContainer); 191 this._headerElement.appendChild(this._frameContainer);
192 }, 192 },
193 193
194 _onFrameDoubleClicked: function(event) 194 _onFrameDoubleClicked: function(event)
195 { 195 {
(...skipping 1099 matching lines...) Expand 10 before | Expand all | Expand 10 after
1295 this._element.classList.remove("hidden"); 1295 this._element.classList.remove("hidden");
1296 } else 1296 } else
1297 this._element.classList.add("hidden"); 1297 this._element.classList.add("hidden");
1298 }, 1298 },
1299 1299
1300 _dispose: function() 1300 _dispose: function()
1301 { 1301 {
1302 this._element.remove(); 1302 this._element.remove();
1303 } 1303 }
1304 } 1304 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698