Issue 335103002: Fix a potential use-after-free after JSONReader::Read.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 335103002: Fix a potential use-after-free after JSONReader::Read. (Closed)

Created:
6 years, 6 months ago by pneubeck (no reviews)

Modified:
6 years, 6 months ago

Reviewers:
markusheintz_

CC:
chromium-reviews, markusheintz_

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix a potential use-after-free after JSONReader::Read. JSONReader produces base::Value objects that share a string buffer. See comment at the JSON_DETACHABLE_CHILDREN option. Since Remove on a child node was used, this potentially lead to use-after-free. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277772