Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Issue 3351022: Make the code compile on Mac OS X (Closed)

Created:
10 years, 3 months ago by yurys
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make the code compile on Mac OS X BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=5442

Patch Set 1 #

Patch Set 2 : Added comment to the code #

Total comments: 2

Patch Set 3 : Changed comment wording in accord with review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/isolate.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
10 years, 3 months ago (2010-09-10 11:30:57 UTC) #1
Vitaly Repeshko
LGTM http://codereview.chromium.org/3351022/diff/2001/3001 File src/isolate.h (right): http://codereview.chromium.org/3351022/diff/2001/3001#newcode299 src/isolate.h:299: // Without these forward declarations the code won't ...
10 years, 3 months ago (2010-09-10 12:07:48 UTC) #2
yurys
10 years, 3 months ago (2010-09-10 13:23:10 UTC) #3
http://codereview.chromium.org/3351022/diff/2001/3001
File src/isolate.h (right):

http://codereview.chromium.org/3351022/diff/2001/3001#newcode299
src/isolate.h:299: // Without these forward declarations the code won't compile
on Mac.
On 2010/09/10 12:07:48, Vitaly wrote:
> How about
> "These forward declarations are required to make the friend declarations in
> PerIsolateThreadData work on some older versions of gcc."
> ?

Done.

Powered by Google App Engine
This is Rietveld 408576698