Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 335083002: Add data reduction proxy bypass logic to system profile (Closed)

Created:
6 years, 6 months ago by bengr
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flywheel-refactor-net-fake-a-redirect-response-headers
Project:
chromium
Visibility:
Public.

Description

Add data reduction proxy bypass logic to system profile BUG=367221 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277757

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/io_thread.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bengr
6 years, 6 months ago (2014-06-16 05:14:32 UTC) #1
Lei Zhang
https://codereview.chromium.org/335083002/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/335083002/diff/1/chrome/browser/io_thread.cc#newcode540 chrome/browser/io_thread.cc:540: globals_->data_reduction_proxy_params.get()); Is this too early? globals_->data_reduction_proxy_params doesn't get set ...
6 years, 6 months ago (2014-06-16 20:48:53 UTC) #2
bengr
https://codereview.chromium.org/335083002/diff/1/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (right): https://codereview.chromium.org/335083002/diff/1/chrome/browser/io_thread.cc#newcode540 chrome/browser/io_thread.cc:540: globals_->data_reduction_proxy_params.get()); On 2014/06/16 20:48:53, Lei Zhang wrote: > Is ...
6 years, 6 months ago (2014-06-17 03:49:33 UTC) #3
Lei Zhang
lgtm
6 years, 6 months ago (2014-06-17 04:13:21 UTC) #4
bengr
The CQ bit was checked by bengr@chromium.org
6 years, 6 months ago (2014-06-17 13:51:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bengr@chromium.org/335083002/20001
6 years, 6 months ago (2014-06-17 13:51:58 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 14:43:40 UTC) #7
Message was sent while issue was closed. 
Change committed as 277757

Powered by Google App Engine
This is Rietveld 408576698