Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 335073002: Revert of Blacklists virtualCamera.ax (Closed)

Created:
6 years, 6 months ago by henrika (OOO until Aug 14)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, caitkp+watch_chromium.org, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Blacklists virtualCamera.ax (https://codereview.chromium.org/325323003/) Reason for revert: No crashes have been found after 37.0.2046.2 and Canary on Windows is now on 37.0.2051.2, hence it looks good. Not sure if was the blacklisting or the "calling CoInitializeEx twice" patch which did the trick here. I would like to revert the blacklisting patch to see if we can cope with the CoInitializeEx patch only. It would be great if we could avoid adding another DLL to the blacklist. Original issue's description: > Blacklists virtualCamera.ax. > > Tries to avoid crash in media::CoreAudioUtil::CreateDeviceEnumerator by blacklisting a DLL which accounts for a large amount of crashes we see in CreateDeviceEnumerator. > > BUG=383715, 378465 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276946 TBR=tommi@chromium.org,robertshield@chromium.org NOTREECHECKS=true NOTRY=true BUG=383715, 378465 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome_elf/blacklist/blacklist.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
henrika (OOO until Aug 14)
Created Revert of Blacklists virtualCamera.ax
6 years, 6 months ago (2014-06-15 13:59:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/335073002/1
6 years, 6 months ago (2014-06-15 13:59:38 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-15 14:00:01 UTC) #3
Message was sent while issue was closed.
Change committed as 277320

Powered by Google App Engine
This is Rietveld 408576698