Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 335063004: Add virtualKeyboardPrivate API permission to ChromeVox manifest. (Closed)

Created:
6 years, 6 months ago by Peter Lundblad
Modified:
6 years, 6 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Add virtualKeyboardPrivate API permission to ChromeVox manifest. This API will be used to send certain keys that are simulated on a braille display. These are function keys such as arrow keys, enter, backspace etc. The virtual keyboard api is used instead of the similar api in the IME api so that these keys can be used outside of text fields and when the Braille IME is not active. BUG=310285 R=dtseng@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Lundblad
6 years, 6 months ago (2014-06-18 03:23:58 UTC) #1
David Tseng
lgtm
6 years, 6 months ago (2014-06-18 14:19:48 UTC) #2
Peter Lundblad
The CQ bit was checked by plundblad@chromium.org
6 years, 6 months ago (2014-06-18 15:13:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/335063004/1
6 years, 6 months ago (2014-06-18 15:15:06 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 18:44:16 UTC) #5
Message was sent while issue was closed.
Change committed as 278134

Powered by Google App Engine
This is Rietveld 408576698