Issue 335053002: Add GN build for some chrome common, chrome net, and resources targets.

Issue 335053002: Add GN build for some chrome common, chrome net, and resources targets. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
Lei Zhang, fighting049

CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, Ilya Sherman, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, asvitkine+watch_chromium.org, tfarina, darin (slow to review), James Su, ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add GN build for some chrome common, chrome net, and resources targets. Slight enhancements to the grit template. R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277517

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Fix path #

Patch Set 4 : Fix sorting #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+232 lines, -9 lines)			Patch
M	BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/config/features.gni	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/BUILD.gn	View	1 2	1 chunk	+21 lines, -0 lines	0 comments	Download
A	chrome/browser/BUILD.gn	View	1 2	1 chunk	+60 lines, -0 lines	0 comments	Download
A +	chrome/browser/ui/webui/omnibox/BUILD.gn	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/chrome_common.gypi	View		3 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/chrome_resources.gyp	View		7 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/chrome_web_ui_mojo_bindings.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/common/BUILD.gn	View	1 2	1 chunk	+22 lines, -0 lines	0 comments	Download
A +	chrome/common/metrics/proto/BUILD.gn	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
A	chrome/common/net/BUILD.gn	View	1 2 3	1 chunk	+71 lines, -0 lines	0 comments	Download
A +	chrome/common/safe_browsing/BUILD.gn	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
A +	chrome/renderer/BUILD.gn	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/gn/secondary/tools/grit/grit_rule.gni	View	1 2 3	3 chunks	+28 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

lgtm https://codereview.chromium.org/335053002/diff/20001/chrome/common/net/BUILD.gn File chrome/common/net/BUILD.gn (right): https://codereview.chromium.org/335053002/diff/20001/chrome/common/net/BUILD.gn#newcode20 chrome/common/net/BUILD.gn:20: "x509_certificate_model.h", nit: with ascii sorting, .h comes right ...

6 years, 6 months ago (2014-06-16 17:58:37 UTC) #2

brettw

Committed patchset #4 manually as r277517 (presubmit successful).

6 years, 6 months ago (2014-06-16 19:30:02 UTC) #3

Message was sent while issue was closed.

Expand Messages | Collapse Messages