Update the find result index "(m of n)" whenever there is an active selection...

chrome/browser/views/find_bar_host_browsertest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/keyboard_codes.h"
 #include "base/message_loop.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_window.h"
 #include "chrome/browser/find_bar_controller.h"
 #include "chrome/browser/find_notification_details.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/tab_contents/tab_contents_view.h"
 #include "chrome/browser/views/find_bar_host.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/test/in_process_browser_test.h"
 #include "chrome/test/ui_test_utils.h"
 #include "views/focus/focus_manager.h"
 
 const std::wstring kSimplePage = L"404_is_enough_for_us.html";
 const std::wstring kFramePage = L"files/find_in_page/frames.html";
 const std::wstring kFrameData = L"files/find_in_page/framedata_general.html";
 const std::wstring kUserSelectPage = L"files/find_in_page/user-select.html";
 const std::wstring kCrashPage = L"files/find_in_page/crash_1341577.html";
 const std::wstring kTooFewMatchesPage = L"files/find_in_page/bug_1155639.html";
 const std::wstring kEndState = L"files/find_in_page/end_state.html";
 const std::wstring kPrematureEnd = L"files/find_in_page/premature_end.html";
 const std::wstring kMoveIfOver = L"files/find_in_page/move_if_obscuring.html";
 const std::wstring kBitstackCrash = L"files/find_in_page/crash_14491.html";
+const std::wstring kSelectChangesOrdinal =
+    L"files/find_in_page/select_changes_ordinal.html";
 
 const bool kBack = false;
 const bool kFwd = true;
 
 const bool kIgnoreCase = false;
 const bool kCaseSensitive = true;
 
 class FindInPageControllerTest : public InProcessBrowserTest {
  public:
   FindInPageControllerTest() {
@@ skipping 178 matching lines @@
   // This should wrap to the top.
   EXPECT_EQ(3, ui_test_utils::FindInPage(tab, L"o",
                                          kFwd, kIgnoreCase, &ordinal));
   EXPECT_EQ(1, ordinal);
   // This should go back to the end.
   EXPECT_EQ(3, ui_test_utils::FindInPage(tab, L"o",
                                          kBack, kIgnoreCase, &ordinal));
   EXPECT_EQ(3, ordinal);
 }
 
+// This tests that the ordinal is correctly adjusted after a selection
+IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
+                       SelectChangesOrdinal_Issue20883) {
+  HTTPTestServer* server = StartHTTPServer();
+
+  // First we navigate to our test content.
+  GURL url = server->TestServerPageW(kSelectChangesOrdinal);
+  ui_test_utils::NavigateToURL(browser(), url);
+
+  TabContents* tab_contents = browser()->GetSelectedTabContents();
+  ASSERT_TRUE(NULL != tab_contents);
+
+  // Search for a text that exists within a link on the page.
+  TabContents* tab = browser()->GetSelectedTabContents();
+  int ordinal = 0;
+  EXPECT_EQ(4, ui_test_utils::FindInPage(tab_contents, L"google",
+                                         kFwd, kIgnoreCase, &ordinal));
+  EXPECT_EQ(1, ordinal);
+
+  // Move the selection to link 1, after searching.
+  std::string result;
+  ui_test_utils::ExecuteJavaScriptAndExtractString(
+      tab_contents->render_view_host(),
+      L"",
+      L"window.domAutomationController.send(selectLink1());",
+      &result);
+
+  // Do a find-next after the selection.  This should move forward
+  // from there to the 3rd instance of 'google'.
+  EXPECT_EQ(4, ui_test_utils::FindInPage(tab, L"google",
+                                         kFwd, kIgnoreCase, &ordinal));
+  EXPECT_EQ(3, ordinal);
+
+  // End the find session.
+  tab_contents->StopFinding(false);
+}
+
 // This test loads a page with frames and makes sure the ordinal returned makes
 // sense.
 IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindInPageMultiFramesOrdinal) {
   HTTPTestServer* server = StartHTTPServer();
 
   // First we navigate to our page.
   GURL url = server->TestServerPageW(kFramePage);
   ui_test_utils::NavigateToURL(browser(), url);
 
   // Search for 'a', which should make the first item active and return
@@ skipping 391 matching lines @@
   // backspace, but that's been proven flaky in the past, so we go straight to
   // tab_contents.
   TabContents* tab_contents = browser()->GetSelectedTabContents();
   // Stop the (non-existing) find operation, and clear the selection (which
   // signals the UI is still active).
   tab_contents->StopFinding(true);
   // Make sure the Find UI flag hasn't been cleared, it must be so that the UI
   // still responds to browser window resizing.
   ASSERT_TRUE(tab_contents->find_ui_active());
 }