Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3051)

Unified Diff: athena/activity/public/activity_factory.h

Issue 335003003: Introduces AppActivity and handler of chrome.shell API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: AppWindowOwner Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: athena/activity/public/activity_factory.h
diff --git a/athena/activity/public/activity_factory.h b/athena/activity/public/activity_factory.h
index c617eee774310f5aa8e6257a8ad1c0aeeac607ee..0d2448a1456b57fcb6a9e7250084c4ddeeb6b5a4 100644
--- a/athena/activity/public/activity_factory.h
+++ b/athena/activity/public/activity_factory.h
@@ -10,6 +10,7 @@
namespace content {
class BrowserContext;
+class WebContents;
}
namespace athena {
@@ -32,9 +33,8 @@ class ATHENA_EXPORT ActivityFactory {
virtual Activity* CreateWebActivity(content::BrowserContext* browser_context,
const GURL& url) = 0;
- // Create an activity of an app.
- virtual Activity* CreateAppActivity(content::BrowserContext* browser_context,
- const std::string& app_id) = 0;
+ // Create an activity of an app with |web_contents|.
+ virtual Activity* CreateAppActivity(content::WebContents* web_contents) = 0;
James Cook 2014/06/16 16:12:30 Not for this CL: Will Athena ever support multi-p
Jun Mukai 2014/06/16 17:46:52 I think eventually it will, but not now.
};
} // namespace athena

Powered by Google App Engine
This is Rietveld 408576698