Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: athena/activity/public/activity_factory.h

Issue 335003003: Introduces AppActivity and handler of chrome.shell API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/shell/test/shell_test.cc ('k') | athena/athena.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/activity/public/activity_factory.h
diff --git a/athena/activity/public/activity_factory.h b/athena/activity/public/activity_factory.h
index c617eee774310f5aa8e6257a8ad1c0aeeac607ee..bc95893e2539de907380bfb1ba58b3bd629ab087 100644
--- a/athena/activity/public/activity_factory.h
+++ b/athena/activity/public/activity_factory.h
@@ -8,6 +8,10 @@
#include "athena/athena_export.h"
#include "url/gurl.h"
+namespace apps {
+class ShellAppWindow;
+}
+
namespace content {
class BrowserContext;
}
@@ -32,9 +36,9 @@ class ATHENA_EXPORT ActivityFactory {
virtual Activity* CreateWebActivity(content::BrowserContext* browser_context,
const GURL& url) = 0;
- // Create an activity of an app.
- virtual Activity* CreateAppActivity(content::BrowserContext* browser_context,
- const std::string& app_id) = 0;
+ // Create an activity of an app with |app_window|. The returned activity
+ // should own |app_window|.
+ virtual Activity* CreateAppActivity(apps::ShellAppWindow* app_window) = 0;
};
} // namespace athena
« no previous file with comments | « apps/shell/test/shell_test.cc ('k') | athena/athena.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698