Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334983008: Remove proxy checking while evaluating via headers. (Closed)

Created:
6 years, 6 months ago by ksimbili1
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove proxy checking while evaluating via headers. BUG=385990 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/renderer/page_load_histograms.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ksimbili1
6 years, 6 months ago (2014-06-18 18:55:02 UTC) #1
Alexei Svitkine (slow)
lgtm
6 years, 6 months ago (2014-06-18 20:28:48 UTC) #2
ksimbili
The CQ bit was checked by ksimbili@google.com
6 years, 6 months ago (2014-06-18 20:40:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksimbili@chromium.org/334983008/1
6 years, 6 months ago (2014-06-18 20:41:34 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 01:41:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/74692)
6 years, 6 months ago (2014-06-19 01:41:48 UTC) #6
ksimbili
6 years, 6 months ago (2014-06-19 01:55:00 UTC) #7
sky
LGTM - if any includes are no longer needed update them too.
6 years, 6 months ago (2014-06-19 17:01:22 UTC) #8
ksimbili
The CQ bit was checked by ksimbili@google.com
6 years, 6 months ago (2014-06-19 17:11:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksimbili@chromium.org/334983008/1
6 years, 6 months ago (2014-06-19 17:12:22 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 17:52:58 UTC) #11
Message was sent while issue was closed. 
Change committed as 278417

Powered by Google App Engine
This is Rietveld 408576698