[NaCl SDK] Remove use of TIOCNACLINPUT from nacl_io/ppapi_simple.

[NaCl SDK] Remove use of TIOCNACLINPUT from nacl_io/ppapi_simple.

This is replaced by NACL_IOC_HANDLEMESSAGE.

BUG=none
R=sbc@chromium.org

[Sam Clegg, 2014-06-17 22:29:29]

Thanks for doing this.. mostly looks great just but maybe lets not switch to
array buffer just yet?

https://codereview.chromium.org/334983007/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/devfs/tty_node.cc (right):

https://codereview.chromium.org/334983007/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/devfs/tty_node.cc:187: }
I hate to do this to you now, but I think the actual payload sould probably just
continue to be a string.  I spoke to rginda about this and it looks like hterm
should be sending utf8 strings.

Also, keeping it as a string will keep the JS side a little more simple, right?

https://codereview.chromium.org/334983007/diff/1/native_client_sdk/src/tests/...
File native_client_sdk/src/tests/nacl_io_test/tty_test.cc (right):

https://codereview.chromium.org/334983007/diff/1/native_client_sdk/src/tests/...
native_client_sdk/src/tests/nacl_io_test/tty_test.cc:203: }
?

[binji, 2014-06-17 22:55:23]

https://codereview.chromium.org/334983007/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/devfs/tty_node.cc (right):

https://codereview.chromium.org/334983007/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/devfs/tty_node.cc:187: }
On 2014/06/17 22:29:28, Sam Clegg wrote:
> I hate to do this to you now, but I think the actual payload sould probably
just
> continue to be a string.  I spoke to rginda about this and it looks like hterm
> should be sending utf8 strings.
> 
> Also, keeping it as a string will keep the JS side a little more simple,
right?

Done.

https://codereview.chromium.org/334983007/diff/1/native_client_sdk/src/tests/...
File native_client_sdk/src/tests/nacl_io_test/tty_test.cc (right):

https://codereview.chromium.org/334983007/diff/1/native_client_sdk/src/tests/...
native_client_sdk/src/tests/nacl_io_test/tty_test.cc:203: }
On 2014/06/17 22:29:29, Sam Clegg wrote:
> ?

Done.

[Sam Clegg, 2014-06-17 23:01:32]

lgtm

https://codereview.chromium.org/334983007/diff/20001/native_client_sdk/src/li...
File native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc (right):

https://codereview.chromium.org/334983007/diff/20001/native_client_sdk/src/li...
native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc:420: }
Should we mode the type checking into the node?

https://codereview.chromium.org/334983007/diff/20001/native_client_sdk/src/li...
native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc:452: close(fd);
Woah..  I guess we need some tests for ppapi_simple!

[binji, 2014-06-17 23:33:09]

https://codereview.chromium.org/334983007/diff/20001/native_client_sdk/src/li...
File native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc (right):

https://codereview.chromium.org/334983007/diff/20001/native_client_sdk/src/li...
native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc:420: }
On 2014/06/17 23:01:31, Sam Clegg wrote:
> Should we mode the type checking into the node?

Looks like it is already there. And the JSPipe one is incorrect, it should be a
dictionary, not an arraybuffer.

https://codereview.chromium.org/334983007/diff/20001/native_client_sdk/src/li...
native_client_sdk/src/libraries/ppapi_simple/ps_instance.cc:452: close(fd);
On 2014/06/17 23:01:31, Sam Clegg wrote:
> Woah..  I guess we need some tests for ppapi_simple!

Yeah, I'm not sure if I'm breaking anything...