Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 334973003: Fix issue where OpenKey() would call Close() and reset the wow64_access to 0 (Closed)

Created:
6 years, 6 months ago by Will Harris
Modified:
6 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Fix issue where OpenKey() would call Close() and reset the wow64_access to 0 causing subsequent OpenKey() to fail. BUG=384587 TEST=base_unittests --gtest_filter=RegistryTest.SameWowFlags Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277889

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M base/win/registry.cc View 1 3 chunks +2 lines, -1 line 0 comments Download
M base/win/registry_unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Will Harris
6 years, 6 months ago (2014-06-13 22:45:40 UTC) #1
grt (UTC plus 2)
lgtm with a small thing i noticed while looking at all calls to Close() https://codereview.chromium.org/334973003/diff/1/base/win/registry.cc ...
6 years, 6 months ago (2014-06-14 13:23:17 UTC) #2
Will Harris
cpu - seeking owner LGTM. Thanks. https://codereview.chromium.org/334973003/diff/1/base/win/registry.cc File base/win/registry.cc (right): https://codereview.chromium.org/334973003/diff/1/base/win/registry.cc#newcode166 base/win/registry.cc:166: wow64access_ = 0; ...
6 years, 6 months ago (2014-06-16 16:04:50 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
6 years, 6 months ago (2014-06-17 16:31:13 UTC) #4
Will Harris
The CQ bit was checked by wfh@chromium.org
6 years, 6 months ago (2014-06-17 17:31:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/334973003/20001
6 years, 6 months ago (2014-06-17 17:33:03 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 23:05:02 UTC) #7
Message was sent while issue was closed.
Change committed as 277889

Powered by Google App Engine
This is Rietveld 408576698