Issue 334973002: Rename CompositingUpdateOnCompositedScroll to CompositingUpdateAfterGeometryChange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334973002: Rename CompositingUpdateOnCompositedScroll to CompositingUpdateAfterGeometryChange (Closed)

Created:
6 years, 6 months ago by abarth-chromium

Modified:
6 years, 6 months ago

Reviewers:
Ian Vollick, esprehn

CC:
esprehn, abarth-chromium, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, hartmanng, jchaffraix+rendering, leviw+renderwatch, ojan, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Rename CompositingUpdateOnCompositedScroll to CompositingUpdateAfterGeometryChange What this update type actually does is update the geometry of all the composited layer mappings that have dirty geometry. Rather than naming the value for its caller, we should name the value for its effect. R=vollick@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176127

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/rendering/RenderLayerScrollableArea.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/rendering/compositing/RenderLayerCompositor.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/334973002/1

6 years, 6 months ago (2014-06-13 18:38:51 UTC) #3

Ian Vollick

On 2014/06/13 18:38:51, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...

6 years, 6 months ago (2014-06-13 19:17:56 UTC) #4

Message was sent while issue was closed.

Change committed as 176127

Expand Messages | Collapse Messages