Issue 33493003: [PDF] Add unpremultiply support and a GM (try4)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 33493003: [PDF] Add unpremultiply support and a GM (try4) (Closed)

Created:
7 years, 2 months ago by vandebo (ex-Chrome)

Modified:
7 years, 2 months ago

Reviewers:
edisonn

CC:
skia-review_googlegroups.com, caryclark, bungeman-skia

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

[PDF] Add unpremultiply support and a GM (try4) This is a resubmit of https://codereview.chromium.org/22831039 which was reverted because it causes issues on Windows (really, release builds). BUG=chromium:175548 R=edisonn@google.com Committed: https://code.google.com/p/skia/source/detail?r=11928

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+294 lines, -2 lines)			Patch
gm/bitmappremul.cpp	View		1 chunk	+131 lines, -0 lines	0 comments	Download
gyp/gmslides.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
src/pdf/SkPDFImage.cpp	View	1	2 chunks	+162 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

vandebo (ex-Chrome)

Problem turns out to be required code in an SkASSERT

7 years, 2 months ago (2013-10-22 23:10:01 UTC) #1

vandebo (ex-Chrome)

7 years, 2 months ago (2013-10-23 20:17:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r11928 (presubmit successful).