chrome/browser/guest_view/web_view/web_view_guest.h - Issue 334923002: Remove ContentBrowserClient::GuestWebContentsAttached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/web_view_guest.h

Issue 334923002: Remove ContentBrowserClient::GuestWebContentsAttached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_adview

Patch Set: Added missing file Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/guest_view/guest_view_base.cc ('K') | « chrome/browser/guest_view/guest_view_manager_factory.h ('k') | chrome/browser/guest_view/web_view/web_view_guest.cc » ('j') | chrome/browser/guest_view/web_view/web_view_guest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/web_view_guest.h

diff --git a/chrome/browser/guest_view/web_view/web_view_guest.h b/chrome/browser/guest_view/web_view/web_view_guest.h

index 32defb5c87197e7ad491a23e44485151e5cb52e2..d02df2432e3b866383cfeb3398aea1037f0b4067 100644

--- a/chrome/browser/guest_view/web_view/web_view_guest.h

+++ b/chrome/browser/guest_view/web_view/web_view_guest.h

@@ -88,8 +88,7 @@ class WebViewGuest : public GuestView<WebViewGuest>,

void SetZoom(double zoom_factor);

// GuestViewBase implementation.

- virtual void Attach(content::WebContents* embedder_web_contents,

- const base::DictionaryValue& args) OVERRIDE;

+ virtual void DidAttach() OVERRIDE;

virtual void DidStopLoading() OVERRIDE;

virtual void EmbedderDestroyed() OVERRIDE;

virtual void GuestDestroyed() OVERRIDE;

@@ -151,7 +150,6 @@ class WebViewGuest : public GuestView<WebViewGuest>,

content::WebContents* new_contents) OVERRIDE;

// BrowserPluginGuestDelegate implementation.

- virtual void DidAttach(const base::DictionaryValue& extra_params) OVERRIDE;

virtual void SizeChanged(const gfx::Size& old_size, const gfx::Size& new_size)

OVERRIDE;

virtual void RequestPointerLockPermission(