Support external startup data in V8. (retry)

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # TODO(jochen): These will need to be user-settable to support standalone V8
 # builds.
 v8_compress_startup_data = "off"
 v8_deprecation_warnings = false
 v8_enable_disassembler = false
 v8_enable_gdbjit = false
 v8_enable_handle_zapping = true
 v8_enable_i18n_support = true
 v8_enable_verify_heap = false
 v8_interpreted_regexp = false
 v8_object_print = false
 v8_postmortem_support = false
 v8_use_default_platform = true
 v8_use_snapshot = true
+v8_use_external_startup_data = false
 v8_enable_extra_checks = is_debug
 v8_target_arch = cpu_arch
 v8_random_seed = "314159265"
 
 
 ###############################################################################
 # Configurations
 #
 config("internal_config") {
   visibility = ":*"  # Only targets in this file can depend on this.
@@ skipping 73 matching lines @@
   if (v8_enable_extra_checks == true) {
     defines += [
       "ENABLE_EXTRA_CHECKS",
     ]
   }
   if (v8_enable_handle_zapping == true) {
     defines += [
       "ENABLE_HANDLE_ZAPPING",
     ]
   }
+  if (v8_use_external_startup_data == true) {
+    defines += [
+      "V8_USE_EXTERNAL_STARTUP_DATA",
+    ]
+  }
 }
 
 config("toolchain") {
   visibility = ":*"  # Only targets in this file can depend on this.
 
   defines = []
   cflags = []
 
   # TODO(jochen): Add support for arm, mips, mipsel.
 
@@ skipping 83 matching lines @@
   ]
 
   outputs = [
     "$target_gen_dir/libraries.cc"
   ]
 
   if (v8_enable_i18n_support) {
     sources += [ "src/i18n.js" ]
   }
 
-  args =
-    rebase_path(outputs, root_build_dir) +
-    [ "CORE", v8_compress_startup_data ] +
-    rebase_path(sources, root_build_dir)
+  args = [
+    rebase_path("$target_gen_dir/libraries.cc", root_build_dir),
+    "CORE",
+    v8_compress_startup_data
+  ] + rebase_path(sources, root_build_dir)
+
+  if (v8_use_external_startup_data) {
+    outputs += [ "$target_gen_dir/libraries.bin" ]
+    args += [
+      "--startup_blob",
+      rebase_path("$target_gen_dir/libraries.bin", root_build_dir)
+    ]
+  }
 }
 
 action("js2c_experimental") {
   visibility = ":*"  # Only targets in this file can depend on this.
 
   script = "tools/js2c.py"
 
   # The script depends on this other script, this rule causes a rebuild if it
   # changes.
   source_prereqs = [ "tools/jsmin.py" ]
 
   sources = [
     "src/macros.py",
     "src/symbol.js",
     "src/proxy.js",
     "src/collection.js",
     "src/collection-iterator.js",
     "src/generator.js",
     "src/array-iterator.js",
     "src/harmony-string.js",
     "src/harmony-array.js",
     "src/harmony-math.js",
   ]
 
   outputs = [
     "$target_gen_dir/experimental-libraries.cc"
   ]
 
-  args =
-    rebase_path(outputs, root_build_dir) +
-    [ "EXPERIMENTAL", v8_compress_startup_data ] +
-    rebase_path(sources, root_build_dir)
+  args = [
+    rebase_path("$target_gen_dir/experimental-libraries.cc", root_build_dir),
+    "EXPERIMENTAL",
+    v8_compress_startup_data
+  ] + rebase_path(sources, root_build_dir)
+
+  if (v8_use_external_startup_data) {
+    outputs += [ "$target_gen_dir/libraries_experimental.bin" ]
+    args += [
+      "--startup_blob",
+      rebase_path("$target_gen_dir/libraries_experimental.bin", root_build_dir)
+    ]
+  }
+}
+
+if (v8_use_external_startup_data) {
+  action("natives_blob") {
+    visibility = ":*"  # Only targets in this file can depend on this.
+
+    deps = [
+      ":js2c",
+      ":js2c_experimental"
+    ]
+
+    sources = [
+      "$target_gen_dir/libraries.bin",
+      "$target_gen_dir/libraries_experimental.bin"
+    ]
+
+    outputs = [
+      "$root_gen_dir/natives_blob.bin"
+    ]
+
+    script = "tools/concatenate-files.py"
+
+    args = rebase_path(sources + outputs, root_build_dir)
+  }
 }
 
 action("postmortem-metadata") {
   visibility = ":*"  # Only targets in this file can depend on this.
 
   script = "tools/gen-postmortem-metadata.py"
 
   sources = [
     "src/objects.h",
     "src/objects-inl.h",
@@ skipping 17 matching lines @@
 
   outputs = [
     "$target_gen_dir/snapshot.cc"
   ]
 
   args = [
     "./" + rebase_path(get_label_info(":mksnapshot($host_toolchain)",
                                       "root_out_dir") + "/mksnapshot",
                        root_build_dir),
     "--log-snapshot-positions",
-    "--logfile", rebase_path("$target_gen_dir/snapshot.log", root_build_dir)
+    "--logfile", rebase_path("$target_gen_dir/snapshot.log", root_build_dir),
+    rebase_path("$target_gen_dir/snapshot.cc", root_build_dir)
   ]
 
   if (v8_random_seed != "0") {
     args += [ "--random-seed", v8_random_seed ]
   }
 
-  args += rebase_path(outputs, root_build_dir)
+  if (v8_use_external_startup_data) {
+    outputs += [ "$root_gen_dir/snapshot_blob.bin" ]
+    args += [
+      "--startup_blob",
+      rebase_path("$root_gen_dir/snapshot_blob.bin", root_build_dir)
+    ]
+  }
 }
 
 
 ###############################################################################
 # Source Sets (aka static libraries)
 #
 
 source_set("v8_nosnapshot") {
   visibility = ":*"  # Only targets in this file can depend on this.
 
   deps = [
     ":js2c",
     ":js2c_experimental",
     ":generate_trig_table",
     ":v8_base",
   ]
 
   sources = [
     "$target_gen_dir/libraries.cc",
     "$target_gen_dir/experimental-libraries.cc",
     "$target_gen_dir/trig-table.cc",
     "src/snapshot-empty.cc",
+    "src/snapshot-common.cc",
   ]
 
   configs -= [ "//build/config/compiler:chromium_code" ]
   configs += [ "//build/config/compiler:no_chromium_code" ]
   configs += [ ":internal_config", ":features", ":toolchain" ]
 }
 
 source_set("v8_snapshot") {
   visibility = ":*"  # Only targets in this file can depend on this.
 
   deps = [
     ":js2c",
     ":js2c_experimental",
     ":generate_trig_table",
     ":run_mksnapshot",
     ":v8_base",
   ]
 
   sources = [
     "$target_gen_dir/libraries.cc",
     "$target_gen_dir/experimental-libraries.cc",
     "$target_gen_dir/trig-table.cc",
     "$target_gen_dir/snapshot.cc",
+    "src/snapshot-common.cc",
   ]
 
   configs -= [ "//build/config/compiler:chromium_code" ]
   configs += [ "//build/config/compiler:no_chromium_code" ]
   configs += [ ":internal_config", ":features", ":toolchain" ]
 }
 
+if (v8_use_external_startup_data) {
+  source_set("v8_external_snapshot") {
+    visibility = ":*"  # Only targets in this file can depend on this.
+
+    deps = [
+      ":js2c",
+      ":js2c_experimental",
+      ":generate_trig_table",
+      ":run_mksnapshot",
+      ":v8_base",
+      ":natives_blob",
+    ]
+
+    sources = [
+      "$target_gen_dir/trig-table.cc",
+      "src/natives-external.cc",
+      "src/snapshot-external.cc",
+    ]
+
+    configs -= [ "//build/config/compiler:chromium_code" ]
+    configs += [ "//build/config/compiler:no_chromium_code" ]
+    configs += [ ":internal_config", ":features", ":toolchain" ]
+  }
+}
+
 source_set("v8_base") {
   visibility = ":*"  # Only targets in this file can depend on this.
 
   sources = [
     "src/accessors.cc",
     "src/accessors.h",
     "src/allocation.cc",
     "src/allocation.h",
     "src/allocation-site-scopes.cc",
     "src/allocation-site-scopes.h",
@@ skipping 283 matching lines @@
     "src/scanner.cc",
     "src/scanner.h",
     "src/scopeinfo.cc",
     "src/scopeinfo.h",
     "src/scopes.cc",
     "src/scopes.h",
     "src/serialize.cc",
     "src/serialize.h",
     "src/small-pointer-list.h",
     "src/smart-pointers.h",
-    "src/snapshot-common.cc",
+    "src/snapshot-source-sink.cc",
+    "src/snapshot-source-sink.h",
     "src/snapshot.h",
     "src/spaces-inl.h",
     "src/spaces.cc",
     "src/spaces.h",
     "src/store-buffer-inl.h",
     "src/store-buffer.cc",
     "src/store-buffer.h",
     "src/string-search.cc",
     "src/string-search.h",
     "src/string-stream.cc",
@@ skipping 355 matching lines @@
 # Public targets
 #
 
 if (component_mode == "shared_library") {
 
 component("v8") {
   sources = [
     "src/v8dll-main.cc",
   ]
 
-  if (v8_use_snapshot) {
+  if (v8_use_external_startup_data) {
+    deps = [
+      ":v8_base",
+      ":v8_external_snapshot",
+    ]
+  } else if (v8_use_snapshot) {
     deps = [
       ":v8_base",
       ":v8_snapshot",
     ]
   } else {
     deps = [
       ":v8_base",
       ":v8_nosnapshot",
     ]
   }
 
   configs -= [ "//build/config/compiler:chromium_code" ]
   configs += [ "//build/config/compiler:no_chromium_code" ]
   configs += [ ":internal_config", ":features", ":toolchain" ]
 
   direct_dependent_configs = [ ":external_config" ]
 
   if (is_android && current_toolchain != host_toolchain) {
     libs += [ "log" ]
   }
 }
 
 } else {
 
 group("v8") {
-  if (v8_use_snapshot) {
+  if (v8_use_external_startup_data) {
+    deps = [
+      ":v8_base",
+      ":v8_external_snapshot",
+    ]
+  } else if (v8_use_snapshot) {
     deps = [
       ":v8_base",
       ":v8_snapshot",
     ]
   } else {
     deps = [
       ":v8_base",
       ":v8_nosnapshot",
     ]
   }
 
   direct_dependent_configs = [ ":external_config" ]
 }
 
 }