Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334903002: Fix windows build (size_t vs. int). (Closed)

Created:
6 years, 6 months ago by marja
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix windows build (size_t vs. int). Sadly, Vector ctor takes an argument "int length". TBR=dcarney@chromium.org, mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21844

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/ast-value-factory.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
marja
Committed patchset #1 manually as r21844 (presubmit successful).
6 years, 6 months ago (2014-06-13 14:25:03 UTC) #1
Michael Starzinger
6 years, 6 months ago (2014-06-13 14:52:17 UTC) #2
Message was sent while issue was closed. 
LGTM (rubber-stamped).

Powered by Google App Engine
This is Rietveld 408576698