[WebSocket] Make subprotocol and extensions live in WebSocket

[WebSocket] Make subprotocol and extensions live in WebSocket

Currently WebSocketChannel has methods subprotocol and extensions.
But they can be available only after the connection is established and
they don't change once set. Futhermore, there is didConnect notification
in WebSocketChannelClient.
This CL removes subprotocol and extensions from WebSocketChannel and
add them as WebSocketChannelClient::didConnect parameters.

BUG=384238
R=tyoshino

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176115

[yhirano, 2014-06-13 08:12:01]

cc to haraken because he is modifying modules/websocket.

[tyoshino (SeeGerritForStatus), 2014-06-13 09:00:12]

Nice cleanup!

lgtm

https://codereview.chromium.org/334873002/diff/1/Source/web/WebSocketImpl.cpp
File Source/web/WebSocketImpl.cpp (right):

https://codereview.chromium.org/334873002/diff/1/Source/web/WebSocketImpl.cpp...
Source/web/WebSocketImpl.cpp:131: m_extensions = extensions;
let's set variables first, and then didConnect()

[yhirano, 2014-06-13 09:04:03]

+tkent for Source/web

https://codereview.chromium.org/334873002/diff/1/Source/web/WebSocketImpl.cpp
File Source/web/WebSocketImpl.cpp (right):

https://codereview.chromium.org/334873002/diff/1/Source/web/WebSocketImpl.cpp...
Source/web/WebSocketImpl.cpp:131: m_extensions = extensions;
On 2014/06/13 09:00:12, tyoshino wrote:
> let's set variables first, and then didConnect()

Done.

[tkent, 2014-06-13 09:18:44]

lgtm

[yhirano, 2014-06-13 09:19:57]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-06-13 09:20:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yhirano@chromium.org/334873002/20001

[commit-bot: I haz the power, 2014-06-13 10:35:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-13 11:23:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 11:23:01]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[yhirano, 2014-06-13 11:34:54]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-06-13 11:35:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yhirano@chromium.org/334873002/20001

[commit-bot: I haz the power, 2014-06-13 12:24:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-13 13:14:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 13:14:18]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[yhirano, 2014-06-13 13:41:59]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-06-13 13:42:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yhirano@chromium.org/334873002/20001

[commit-bot: I haz the power, 2014-06-13 14:42:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-13 15:43:47]

Change committed as 176115