Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 334793005: Minor change: use single quote for JavaScript code in layout tests. (Closed)

Created:
6 years, 6 months ago by ziran.sun
Modified:
6 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Minor change: use single quote for JavaScript code in layout tests. R=tkent@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M LayoutTests/fast/forms/suggested-value.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggested-value-after-setvalue.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
ziran.sun
Please review. Thanks!
6 years, 6 months ago (2014-06-13 10:39:19 UTC) #1
tkent
lgtm
6 years, 6 months ago (2014-06-15 23:43:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/334793005/1
6 years, 6 months ago (2014-06-15 23:43:50 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 01:42:33 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12025)
6 years, 6 months ago (2014-06-16 01:42:34 UTC) #5
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-16 08:13:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/334793005/1
6 years, 6 months ago (2014-06-16 08:13:21 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 08:54:47 UTC) #8
Message was sent while issue was closed.
Change committed as 176191

Powered by Google App Engine
This is Rietveld 408576698