Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 334793003: Change some cmpq to cmpp, times_8 to times_pointer_size for x32 port. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 2932 matching lines...) Expand 10 before | Expand all | Expand 10 after
2943 // Skip loop if no descriptors are valid. 2943 // Skip loop if no descriptors are valid.
2944 __ NumberOfOwnDescriptors(rcx, rbx); 2944 __ NumberOfOwnDescriptors(rcx, rbx);
2945 __ cmpp(rcx, Immediate(0)); 2945 __ cmpp(rcx, Immediate(0));
2946 __ j(equal, &done); 2946 __ j(equal, &done);
2947 2947
2948 __ LoadInstanceDescriptors(rbx, r8); 2948 __ LoadInstanceDescriptors(rbx, r8);
2949 // rbx: descriptor array. 2949 // rbx: descriptor array.
2950 // rcx: valid entries in the descriptor array. 2950 // rcx: valid entries in the descriptor array.
2951 // Calculate the end of the descriptor array. 2951 // Calculate the end of the descriptor array.
2952 __ imulp(rcx, rcx, Immediate(DescriptorArray::kDescriptorSize)); 2952 __ imulp(rcx, rcx, Immediate(DescriptorArray::kDescriptorSize));
2953 __ leap(rcx, Operand(r8, rcx, times_8, DescriptorArray::kFirstOffset)); 2953 __ leap(rcx,
2954 Operand(r8, rcx, times_pointer_size, DescriptorArray::kFirstOffset));
2954 // Calculate location of the first key name. 2955 // Calculate location of the first key name.
2955 __ addp(r8, Immediate(DescriptorArray::kFirstOffset)); 2956 __ addp(r8, Immediate(DescriptorArray::kFirstOffset));
2956 // Loop through all the keys in the descriptor array. If one of these is the 2957 // Loop through all the keys in the descriptor array. If one of these is the
2957 // internalized string "valueOf" the result is false. 2958 // internalized string "valueOf" the result is false.
2958 __ jmp(&entry); 2959 __ jmp(&entry);
2959 __ bind(&loop); 2960 __ bind(&loop);
2960 __ movp(rdx, FieldOperand(r8, 0)); 2961 __ movp(rdx, FieldOperand(r8, 0));
2961 __ Cmp(rdx, isolate()->factory()->value_of_string()); 2962 __ Cmp(rdx, isolate()->factory()->value_of_string());
2962 __ j(equal, if_false); 2963 __ j(equal, if_false);
2963 __ addp(r8, Immediate(DescriptorArray::kDescriptorSize * kPointerSize)); 2964 __ addp(r8, Immediate(DescriptorArray::kDescriptorSize * kPointerSize));
(...skipping 1839 matching lines...) Expand 10 before | Expand all | Expand 10 after
4803 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 4804 ASSERT_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
4804 Assembler::target_address_at(call_target_address, 4805 Assembler::target_address_at(call_target_address,
4805 unoptimized_code)); 4806 unoptimized_code));
4806 return OSR_AFTER_STACK_CHECK; 4807 return OSR_AFTER_STACK_CHECK;
4807 } 4808 }
4808 4809
4809 4810
4810 } } // namespace v8::internal 4811 } } // namespace v8::internal
4811 4812
4812 #endif // V8_TARGET_ARCH_X64 4813 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698