Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 334793003: Change some cmpq to cmpp, times_8 to times_pointer_size for x32 port. (Closed)

Created:
6 years, 6 months ago by haitao.feng
Modified:
6 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Change some cmpq to cmpp, times_8 to times_pointer_size for x32 port. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M src/x64/code-stubs-x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
haitao.feng
Hi Toon, PTAL. This is the one more patch we discussed in the talk. It ...
6 years, 6 months ago (2014-06-13 05:20:54 UTC) #1
haitao.feng
Friendly ping.
6 years, 6 months ago (2014-06-23 05:48:37 UTC) #2
Toon Verwaest
lgtm
6 years, 6 months ago (2014-06-23 13:44:07 UTC) #3
haitao.feng
6 years, 6 months ago (2014-06-24 03:40:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21953.

Powered by Google App Engine
This is Rietveld 408576698