components/component_updater/browser/component_updater_switches.h - Issue 334783002: Componentize component_updater: Move some paths/constants to component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/component_updater/browser/component_updater_switches.h

Issue 334783002: Componentize component_updater: Move some paths/constants to component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/component_updater/DEPS ('K') | « components/component_updater/DEPS ('k') | components/component_updater/browser/component_updater_switches.cc » ('j') | components/component_updater/common/component_updater_paths.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/component_updater/browser/component_updater_switches.h

diff --git a/apps/shell/common/switches.h b/components/component_updater/browser/component_updater_switches.h

similarity index 56%

copy from apps/shell/common/switches.h

copy to components/component_updater/browser/component_updater_switches.h

index 2ea9f107746a5dd91a964900925846bd0415debe..14085b4d2c93ad78321422164785f00ced218d16 100644

--- a/apps/shell/common/switches.h

+++ b/components/component_updater/browser/component_updater_switches.h

@@ -2,18 +2,15 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#ifndef APPS_SHELL_COMMON_SWITCHES_H_

-#define APPS_SHELL_COMMON_SWITCHES_H_

+#ifndef COMPONENTS_COMPONENT_UPDATER_BROWSER_COMPONENT_UPDATER_SWITCHES_H_

Sorin Jianu 2014/06/30 22:27:53 I wonder why this does not look like a new file.

tommycli 2014/07/01 00:03:04 I think 'git' detects this as a copy, since the co

+#define COMPONENTS_COMPONENT_UPDATER_BROWSER_COMPONENT_UPDATER_SWITCHES_H_

-namespace apps {

namespace switches {

// All switches in alphabetical order. The switches should be documented

// alongside the definition of their values in the .cc file.

-extern const char kApp[];

-extern const char kHostWindowBounds[];

+extern const char kComponentUpdater[];

} // namespace switches

-} // namespace apps

-#endif // APPS_SHELL_COMMON_SWITCHES_H_

+#endif // COMPONENTS_COMPONENT_UPDATER_BROWSER_COMPONENT_UPDATER_SWITCHES_H_