Componentize component_updater: Move some paths/constants to component.

chrome/browser/component_updater/cld_component_installer.h

Index: chrome/browser/component_updater/cld_component_installer.h
diff --git a/chrome/browser/component_updater/cld_component_installer.h b/chrome/browser/component_updater/cld_component_installer.h
index 9e92c71128d732e6b092583b763bcfa219591835..c66be61bafa9913c045c412c1bf336b9f5c0003b 100644
--- a/chrome/browser/component_updater/cld_component_installer.h
+++ b/chrome/browser/component_updater/cld_component_installer.h
@@ -23,7 +23,8 @@ class ComponentUpdateService;
 // Visible for testing. No need to instantiate this class directly.
 class CldComponentInstallerTraits : public ComponentInstallerTraits {
  public:
-  CldComponentInstallerTraits();
+  CldComponentInstallerTraits(const base::FilePath& base_dir,
+                              const base::FilePath& data_filename);
   virtual ~CldComponentInstallerTraits() {}
 
  private:
@@ -52,14 +53,20 @@ class CldComponentInstallerTraits : public ComponentInstallerTraits {
   virtual void GetHash(std::vector<uint8>* hash) const OVERRIDE;
   virtual std::string GetName() const OVERRIDE;
 
-  static base::FilePath GetInstalledPath(const base::FilePath& base);
+  base::FilePath GetInstalledPath(const base::FilePath& base) const;

[Sorin Jianu, 2014/06/19 00:48:22]

It would be nice to not have to touch the definition of component installers as
a result of this refactoring. Especially, change the interface to their class.

[tommycli, 2014/06/23 21:55:28]

Done.

   static void SetLatestCldDataFile(const base::FilePath& path);
+
+  base::FilePath base_dir_;
+  base::FilePath data_filename_;
+
   DISALLOW_COPY_AND_ASSIGN(CldComponentInstallerTraits);
 };
 
 // Call once during startup to make the component update service aware of
 // the CLD component.
-void RegisterCldComponent(ComponentUpdateService* cus);
+void RegisterCldComponent(ComponentUpdateService* cus,
+                          const base::FilePath& base_dir,
+                          const base::FilePath& data_filename);
 
 // Returns the path to the latest CLD data file into the specified path object,
 // or an empty path if the CLD data file has not been observed yet.