Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 334783002: Componentize component_updater: Move some paths/constants to component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index 01e0d306124af77fbe1edf0330537b559eca7a2e..63f40528de3db7cf7f62d77cbec1cefc75f2ec76 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -70,6 +70,7 @@
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
+#include "chrome/common/chrome_version_info.h"
#include "chrome/common/extensions/chrome_extensions_client.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/switch_utils.h"
@@ -800,7 +801,9 @@ BrowserProcessImpl::component_updater() {
io_thread()->system_url_request_context_getter());
// Creating the component updater does not do anything, components
// need to be registered and Start() needs to be called.
- component_updater_.reset(ComponentUpdateServiceFactory(configurator));
+ component_updater_.reset(ComponentUpdateServiceFactory(
+ configurator, chrome::VersionInfo().Version(),
blundell 2014/06/17 19:16:24 nit: I think these should all be on separate lines
tommycli 2014/06/17 19:31:07 Done.
+ chrome::VersionInfo().OSType()));
}
return component_updater_.get();
}

Powered by Google App Engine
This is Rietveld 408576698