Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: chrome/browser/component_updater/update_checker.cc

Issue 334783002: Componentize component_updater: Move some paths/constants to component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/component_updater/update_checker.cc
diff --git a/chrome/browser/component_updater/update_checker.cc b/chrome/browser/component_updater/update_checker.cc
index 061671aa6a999db22039c9213b6d8728987a6a7e..b5cd6a494875de6ae0e82cfd02a153d92ace7f05 100644
--- a/chrome/browser/component_updater/update_checker.cc
+++ b/chrome/browser/component_updater/update_checker.cc
@@ -32,7 +32,9 @@ namespace component_updater {
// <package fp="abcd" />
// </packages>
// </app>
-std::string BuildUpdateCheckRequest(const std::vector<CrxUpdateItem*>& items,
+std::string BuildUpdateCheckRequest(const std::string& chrome_version,
+ const std::string& platform_name,
+ const std::vector<CrxUpdateItem*>& items,
const std::string& additional_attributes) {
std::string app_elements;
for (size_t i = 0; i != items.size(); ++i) {
@@ -58,7 +60,8 @@ std::string BuildUpdateCheckRequest(const std::vector<CrxUpdateItem*>& items,
VLOG(1) << "Appending to update request: " << app;
}
- return BuildProtocolRequest(app_elements, additional_attributes);
+ return BuildProtocolRequest(chrome_version, platform_name, app_elements,
+ additional_attributes);
}
class UpdateCheckerImpl : public UpdateChecker, public net::URLFetcherDelegate {
@@ -70,6 +73,8 @@ class UpdateCheckerImpl : public UpdateChecker, public net::URLFetcherDelegate {
// Overrides for UpdateChecker.
virtual bool CheckForUpdates(
+ const std::string& chrome_version,
+ const std::string& platform_name,
const std::vector<CrxUpdateItem*>& items_to_check,
const std::string& additional_attributes) OVERRIDE;
@@ -110,6 +115,8 @@ UpdateCheckerImpl::~UpdateCheckerImpl() {
}
bool UpdateCheckerImpl::CheckForUpdates(
+ const std::string& chrome_version,
+ const std::string& platform_name,
const std::vector<CrxUpdateItem*>& items_to_check,
const std::string& additional_attributes) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ -119,7 +126,8 @@ bool UpdateCheckerImpl::CheckForUpdates(
url_fetcher_.reset(SendProtocolRequest(
url_,
- BuildUpdateCheckRequest(items_to_check, additional_attributes),
+ BuildUpdateCheckRequest(chrome_version, platform_name, items_to_check,
+ additional_attributes),
this,
url_request_context_getter_));

Powered by Google App Engine
This is Rietveld 408576698