chrome/browser/component_updater/component_updater_ping_manager.h - Issue 334783002: Componentize component_updater: Move some paths/constants to component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/component_updater_ping_manager.h

Issue 334783002: Componentize component_updater: Move some paths/constants to component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_browser_main.cc ('K') | « chrome/browser/component_updater/component_updater_configurator.cc ('k') | chrome/browser/component_updater/component_updater_ping_manager.cc » ('j') | chrome/browser/component_updater/recovery_component_installer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/component_updater_ping_manager.h

diff --git a/chrome/browser/component_updater/component_updater_ping_manager.h b/chrome/browser/component_updater/component_updater_ping_manager.h

index 1bb0a8b9dd3f5fd442f991d68c7212168ffd71f5..cd655c682bdf5ffe769f22d2a19ba73a3ff2d1db 100644

--- a/chrome/browser/component_updater/component_updater_ping_manager.h

+++ b/chrome/browser/component_updater/component_updater_ping_manager.h

@@ -20,13 +20,16 @@ struct CrxUpdateItem;

// and sends fire-and-forget pings when handling these events.

class PingManager {

public:

- PingManager(const GURL& ping_url,

+ PingManager(const std::string& chrome_version,

blundell 2014/06/17 17:26:43 s/chrome_version/application_version (since the co

tommycli 2014/06/17 19:01:57 Done.

+ const std::string& platform_name, const GURL& ping_url,

net::URLRequestContextGetter* url_request_context_getter);

~PingManager();

void OnUpdateComplete(const CrxUpdateItem* item);

private:

+ const std::string chrome_version_;

+ const std::string platform_name_;

const GURL ping_url_;

// This member is not owned by this class.