components/component_updater.gypi - Issue 334783002: Componentize component_updater: Move some paths/constants to component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/component_updater.gypi

Issue 334783002: Componentize component_updater: Move some paths/constants to component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 # Copyright 2014 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'targets': [

	7 {

	8 'target_name': 'component_updater',

	9 'type': 'static_library',

	10 'dependencies': [

	11 '../base/base.gyp:base',

	12 ],

	13 'include_dirs': [

	14 '..',

	15 ],

	16 'sources': [

	17 'component_updater/browser/component_updater_switches.cc',
	Sorin Jianu 2014/06/30 22:27:53 That is another the part I am not certain about. D That is another the part I am not certain about. Do we need "browser" and "common" directories? Do we need all these files or can we move all or most of these constants into a component_updater_constants instead of few constants in many files. Just an idea. tommycli 2014/07/01 00:03:04 Done. Show quoted text On 2014/06/30 22:27:53, Sorin Jianu wrote: > That is another the part I am not certain about. Do we need "browser" and > "common" directories? > Do we need all these files or can we move all or most of these constants into a > component_updater_constants instead of few constants in many files. Just an > idea. > Done.
	18 'component_updater/browser/component_updater_switches.h',

	19 'component_updater/common/component_updater_constants.cc',

	20 'component_updater/common/component_updater_constants.h',

	21 'component_updater/common/component_updater_paths.cc',

	22 'component_updater/common/component_updater_paths.h',

	23 'component_updater/common/pref_names.cc',

	24 'component_updater/common/pref_names.h',

	25 ],

	26 },

	27 ],

	28 }

OLD	NEW

« chrome/common/chrome_paths.cc ('K') | « chrome/test/base/chrome_unit_test_suite.cc ('k') | components/component_updater/DEPS » ('j') | components/component_updater/DEPS » ('J')