Componentize component_updater: Move some paths/constants to component.

chrome/browser/component_updater/component_updater_ping_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/component_updater/component_updater_ping_manager.h"
 
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/guid.h"
@@ skipping 20 matching lines @@
       return "unknown";
   }
 }
 
 // Sends a fire and forget ping. The instances of this class have no
 // ownership and they self-delete upon completion.
 class PingSender : public net::URLFetcherDelegate {
  public:
   PingSender();
 
-  void SendPing(const GURL& ping_url,
+  void SendPing(const std::string& application_version,
+                const std::string& platform_name,
+                const GURL& ping_url,
                 net::URLRequestContextGetter* url_request_context_getter,
                 const CrxUpdateItem* item);
 
  private:
   virtual ~PingSender();
 
   // Overrides for URLFetcherDelegate.
   virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
 
-  static std::string BuildPing(const CrxUpdateItem* item);
+  static std::string BuildPing(const std::string& application_version,
+                               const std::string& platform_name,
+                               const CrxUpdateItem* item);
   static std::string BuildDownloadCompleteEventElements(
       const CrxUpdateItem* item);
   static std::string BuildUpdateCompleteEventElement(const CrxUpdateItem* item);
 
   scoped_ptr<net::URLFetcher> url_fetcher_;
 
   DISALLOW_COPY_AND_ASSIGN(PingSender);
 };
 
 PingSender::PingSender() {
 }
 
 PingSender::~PingSender() {
 }
 
 void PingSender::OnURLFetchComplete(const net::URLFetcher* source) {
   delete this;
 }
 
 void PingSender::SendPing(
+    const std::string& application_version,
+    const std::string& platform_name,
     const GURL& ping_url,
     net::URLRequestContextGetter* url_request_context_getter,
     const CrxUpdateItem* item) {
   DCHECK(item);
 
   if (!ping_url.is_valid())
     return;
 
-  url_fetcher_.reset(SendProtocolRequest(
-      ping_url, BuildPing(item), this, url_request_context_getter));
+  url_fetcher_.reset(
+      SendProtocolRequest(ping_url,
+                          BuildPing(application_version, platform_name, item),
+                          this,
+                          url_request_context_getter));
 }
 
 // Builds a ping message for the specified update item.
-std::string PingSender::BuildPing(const CrxUpdateItem* item) {
+std::string PingSender::BuildPing(const std::string& application_version,
+                                  const std::string& platform_name,
+                                  const CrxUpdateItem* item) {
   const char app_element_format[] =
       "<app appid=\"%s\" version=\"%s\" nextversion=\"%s\">"
       "%s"
       "%s"
       "</app>";
   const std::string app_element(base::StringPrintf(
       app_element_format,
       item->id.c_str(),                                    // "appid"
       item->previous_version.GetString().c_str(),          // "version"
       item->next_version.GetString().c_str(),              // "nextversion"
       BuildUpdateCompleteEventElement(item).c_str(),       // update event
       BuildDownloadCompleteEventElements(item).c_str()));  // download events
 
-  return BuildProtocolRequest(app_element, "");
+  return BuildProtocolRequest(
+      application_version, platform_name, app_element, "");

[Sorin Jianu, 2014/06/19 00:48:22]

It looks to me that the additional member variables are just used to call the
free standing public functions in the
"chrome/browser/component_updater/component_updater_utils.h".

In this case, I suggest making the builder functions in the
component_updater_utils.h a builder class, which can take a dependency of the
Configurator, and have the Configurator return these versions and platform name.
I can do this change and you can then rebase that on me.

 }
 
 // Returns a string representing a sequence of download complete events
 // corresponding to each download metrics in |item|.
 std::string PingSender::BuildDownloadCompleteEventElements(
     const CrxUpdateItem* item) {
   using base::StringAppendF;
   std::string download_events;
   for (size_t i = 0; i != item->download_metrics.size(); ++i) {
     const CrxDownloader::DownloadMetrics& metrics = item->download_metrics[i];
@@ skipping 62 matching lines @@
   }
   if (!item->previous_fp.empty())
     StringAppendF(&ping_event, " previousfp=\"%s\"", item->previous_fp.c_str());
   if (!item->next_fp.empty())
     StringAppendF(&ping_event, " nextfp=\"%s\"", item->next_fp.c_str());
   StringAppendF(&ping_event, "/>");
   return ping_event;
 }
 
 PingManager::PingManager(
+    const std::string& application_version,
+    const std::string& platform_name,
     const GURL& ping_url,
     net::URLRequestContextGetter* url_request_context_getter)
-    : ping_url_(ping_url),
+    : application_version_(application_version),
+      platform_name_(platform_name),
+      ping_url_(ping_url),
       url_request_context_getter_(url_request_context_getter) {
 }
 
 PingManager::~PingManager() {
 }
 
 // Sends a fire and forget ping when the updates are complete. The ping
 // sender object self-deletes after sending the ping.
 void PingManager::OnUpdateComplete(const CrxUpdateItem* item) {
   PingSender* ping_sender(new PingSender);
-  ping_sender->SendPing(ping_url_, url_request_context_getter_, item);
+  ping_sender->SendPing(application_version_,
+                        platform_name_,
+                        ping_url_,
+                        url_request_context_getter_,
+                        item);
 }
 
 }  // namespace component_updater