Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1959)

Unified Diff: src/types.h

Issue 334763003: Start using OStreams. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Reduced diff Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/code-stubs.h ('K') | « src/string-stream.cc ('k') | src/types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/types.h
diff --git a/src/types.h b/src/types.h
index aaa76e4f3dc423e1548c3650baa72884cf99c2c8..3ecf7462d1f01e72531a3e937676879db9542371 100644
--- a/src/types.h
+++ b/src/types.h
@@ -6,6 +6,7 @@
#define V8_TYPES_H_
#include "src/handles.h"
+#include "src/ostreams.h"
namespace v8 {
namespace internal {
@@ -415,9 +416,7 @@ class TypeImpl : public Config::Base {
enum PrintDimension { BOTH_DIMS, SEMANTIC_DIM, REPRESENTATION_DIM };
- void PrintTo(StringStream* stream, PrintDimension = BOTH_DIMS);
- void TypePrint(PrintDimension = BOTH_DIMS);
- void TypePrint(FILE* out, PrintDimension = BOTH_DIMS);
+ OStream& PrintTo(OStream& os, PrintDimension dim = BOTH_DIMS); // NOLINT
Michael Starzinger 2014/07/02 15:14:58 suggestion: Likewise.
Sven Panne 2014/07/03 07:18:52 Done.
protected:
// Friends.
@@ -502,7 +501,7 @@ class TypeImpl<Config>::BitsetType : public TypeImpl<Config> {
static int InherentLub(TypeImpl* type);
static const char* Name(int bitset);
- static void PrintTo(StringStream* stream, int bitset);
+ static OStream& Print(OStream& os, int bitset); // NOLINT
Michael Starzinger 2014/07/02 15:14:58 suggestion: Likewise.
Sven Panne 2014/07/03 07:18:52 Done.
using TypeImpl::PrintTo;
};
« src/code-stubs.h ('K') | « src/string-stream.cc ('k') | src/types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698