Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 334763003: Start using OStreams. (Closed)

Created:
6 years, 5 months ago by Sven Panne
Modified:
6 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Start using OStreams. Note that until everything is OStream-based, there are a few places where we have to do some impedance matching. A few accessors had to be const-corrected on the way. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22179

Patch Set 1 #

Patch Set 2 : Reduced diff #

Total comments: 6

Patch Set 3 : Rebased. Reformatted. Feedback addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+501 lines, -574 lines) Patch
M src/arm/code-stubs-arm.h View 1 2 7 chunks +14 lines, -16 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.h View 1 2 8 chunks +16 lines, -18 lines 0 comments Download
M src/code-stubs.h View 1 2 74 chunks +150 lines, -151 lines 0 comments Download
M src/code-stubs.cc View 1 2 11 chunks +126 lines, -120 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-dce.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M src/hydrogen-gvn.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 2 chunks +12 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 5 chunks +10 lines, -10 lines 0 comments Download
M src/ic.h View 1 2 5 chunks +8 lines, -4 lines 0 comments Download
M src/ic.cc View 1 2 3 chunks +21 lines, -27 lines 0 comments Download
M src/isolate.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/log.cc View 1 2 4 chunks +16 lines, -21 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +17 lines, -19 lines 0 comments Download
M src/property.cc View 1 1 chunk +21 lines, -20 lines 0 comments Download
M src/string-stream.h View 2 chunks +0 lines, -40 lines 0 comments Download
M src/string-stream.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/types.h View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M src/types.cc View 1 2 1 chunk +54 lines, -74 lines 0 comments Download
M src/typing.cc View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M src/x64/code-stubs-x64.h View 5 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
6 years, 5 months ago (2014-06-30 14:36:34 UTC) #1
Michael Starzinger
LGTM (one comment/suggestion). https://codereview.chromium.org/334763003/diff/20001/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/334763003/diff/20001/src/code-stubs.h#newcode201 src/code-stubs.h:201: virtual OStream& PrintName(OStream& os) const; // ...
6 years, 5 months ago (2014-07-02 15:14:58 UTC) #2
Sven Panne
https://codereview.chromium.org/334763003/diff/20001/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/334763003/diff/20001/src/code-stubs.h#newcode201 src/code-stubs.h:201: virtual OStream& PrintName(OStream& os) const; // NOLINT On 2014/07/02 ...
6 years, 5 months ago (2014-07-03 07:18:52 UTC) #3
Sven Panne
6 years, 5 months ago (2014-07-03 07:19:08 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r22179 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698